From 25c2ecfbdfb392b57a164eb881d9b110fe1f1f68 Mon Sep 17 00:00:00 2001
From: "Burns, Terry" <Terry.Burns@ricardo.com>
Date: Tue, 23 Dec 2014 15:12:34 +0000
Subject: [PATCH] ADDING DIAGNOSTIC OUTPUTS TO PUBLIC ADVANCEDAUXILIARIES &
cMOD IN VECTO
git-tfs-id: [http://tfs00.element.root.com:8080/tfs/TFSCollection]$/VECTO;C1703
---
.../AdvancedAuxiliaryInterfaces.vbproj | 2 +
AdvancedAuxiliaryInterfaces/Diagnostics.vb | 35 +++++++
.../IAdvancedAuxiliaries.vb | 20 +++-
AdvancedAuxiliaryInterfaces/IDiagnostics.vb | 21 ++++
AdvancedAuxiliaryInterfaces/ISignals.vb | 1 +
AdvancedAuxiliaryInterfaces/Signals.vb | 2 +
VECTO/GUI/F_VECTO.vb | 2 -
VECTO/MODcalc/cMOD.vb | 34 +++++++
VECTO/My Project/AssemblyInfo.vb | 4 +-
.../VectoAuxiliaries/AdvancedAuxiliaries.vb | 96 ++++++++++++++++++-
.../DownstreamModules/IM13.vb | 6 +-
.../VectoAuxiliaries/DownstreamModules/IM7.vb | 6 +-
.../VectoAuxiliaries/DownstreamModules/IM8.vb | 6 +-
.../VectoAuxiliaries/DownstreamModules/M13.vb | 2 +-
.../Electrics/AlternatorMap.vb | 2 +-
.../Electrics/ElectricsUserInputsConfig.vb | 2 +-
.../Electrics/IElectricsUserInputsConfig.vb | 2 +-
.../VectoAuxiliaries/Electrics/ResultCard.vb | 2 +-
.../M3_AveragePneumaticLoadDemand.vb | 2 +-
.../Pneumatics/M4_AirCompressor.vb | 11 +--
VECTOAux/VectoAuxiliaries/UI/FB_Global.vb | 4 +-
.../VectoAuxiliaries/UI/frmAuxiliaryConfig.vb | 8 +-
.../Mocks/MockFuel50PC.vb | 10 +-
.../UnitTests/M13Tests.vb | 2 +-
24 files changed, 237 insertions(+), 45 deletions(-)
create mode 100644 AdvancedAuxiliaryInterfaces/Diagnostics.vb
create mode 100644 AdvancedAuxiliaryInterfaces/IDiagnostics.vb
diff --git a/AdvancedAuxiliaryInterfaces/AdvancedAuxiliaryInterfaces.vbproj b/AdvancedAuxiliaryInterfaces/AdvancedAuxiliaryInterfaces.vbproj
index 55193dbb87..6c72421bf9 100644
--- a/AdvancedAuxiliaryInterfaces/AdvancedAuxiliaryInterfaces.vbproj
+++ b/AdvancedAuxiliaryInterfaces/AdvancedAuxiliaryInterfaces.vbproj
@@ -67,8 +67,10 @@
<Import Include="System.Threading.Tasks" />
</ItemGroup>
<ItemGroup>
+ <Compile Include="Diagnostics.vb" />
<Compile Include="Enumerations.vb" />
<Compile Include="IAdvancedAuxiliaries.vb" />
+ <Compile Include="IDiagnostics.vb" />
<Compile Include="ISignals.vb" />
<Compile Include="IAuxiliaryEvent.vb" />
<Compile Include="IVectoInputs.vb" />
diff --git a/AdvancedAuxiliaryInterfaces/Diagnostics.vb b/AdvancedAuxiliaryInterfaces/Diagnostics.vb
new file mode 100644
index 0000000000..568feae2fd
--- /dev/null
+++ b/AdvancedAuxiliaryInterfaces/Diagnostics.vb
@@ -0,0 +1,35 @@
+
+
+Public Class Diagnostics
+Implements IDiagnostics
+
+
+ Public Property AA_CompressorFlag As Integer Implements IDiagnostics.AA_CompressorFlag
+
+ Public Property AA_CompressorFlowRate_LitrePerSec As Single Implements IDiagnostics.AA_CompressorFlowRate_LitrePerSec
+
+ Public Property AA_EngineIdleFlag As Integer Implements IDiagnostics.AA_EngineIdleFlag
+
+ Public Property AA_NonSmartAlternatorsEfficiency As Single Implements IDiagnostics.AA_NonSmartAlternatorsEfficiency
+
+ Public Property AA_OverrunFlag As Integer Implements IDiagnostics.AA_OverrunFlag
+
+ Public Property AA_SmartIdleAlternatorsEfficiency As Single Implements IDiagnostics.AA_SmartIdleAlternatorsEfficiency
+
+ Public Property AA_SmartIdleCurrent_Amps As Single Implements IDiagnostics.AA_SmartIdleCurrent_Amps
+
+ Public Property AA_SmartOverrunAlternatorEfficiency As Single Implements IDiagnostics.AA_SmartOverrunAlternatorEfficiency
+
+ Public Property AA_SmartOverrunCurrent_Amps As Single Implements IDiagnostics.AA_SmartOverrunCurrent_Amps
+
+ Public Property AA_SmartTractionAlternatorEfficiency As Single Implements IDiagnostics.AA_SmartTractionAlternatorEfficiency
+
+ Public Property AA_SmartTractionCurrent_Amps As Single Implements IDiagnostics.AA_SmartTractionCurrent_Amps
+
+ Public Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams As Single Implements IDiagnostics.AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams
+
+ Public Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres As Single Implements IDiagnostics.AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres
+
+
+End Class
+
diff --git a/AdvancedAuxiliaryInterfaces/IAdvancedAuxiliaries.vb b/AdvancedAuxiliaryInterfaces/IAdvancedAuxiliaries.vb
index 8984b807ff..2a323a9441 100644
--- a/AdvancedAuxiliaryInterfaces/IAdvancedAuxiliaries.vb
+++ b/AdvancedAuxiliaryInterfaces/IAdvancedAuxiliaries.vb
@@ -6,11 +6,27 @@ Public Interface IAdvancedAuxiliaries
'Information
ReadOnly Property Running As boolean
-Readonly Property TotalFuelGRAMS As Single
-Readonly Property TotalFuelLITRES As single
+
ReadOnly Property AuxiliaryName As String
ReadOnly Property AuxiliaryVersion As String
+ReadOnly Property AA_NonSmartAlternatorsEfficiency As single?
+Readonly Property AA_SmartIdleCurrent_Amps As single?
+Readonly Property AA_SmartIdleAlternatorsEfficiency As single?
+ReadOnly Property AA_SmartTractionCurrent_Amps As single?
+ReadOnly Property AA_SmartTractionAlternatorEfficiency As single?
+ReadOnly Property AA_SmartOverrunCurrent_Amps As Single?
+Readonly Property AA_SmartOverrunAlternatorEfficiency As Single?
+Readonly Property AA_CompressorFlowRate_LitrePerSec As Single?
+ReadOnly Property AA_OverrunFlag As integer?
+ReadOnly Property AA_EngineIdleFlag As integer?
+ReadOnly Property AA_CompressorFlag As integer?
+Readonly Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams As single?
+ReadOnly Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres As single?
+
+Readonly Property TotalFuelGRAMS As Single
+Readonly Property TotalFuelLITRES As single
+
'Static Values
property VectoInputs As IVectoInputs
diff --git a/AdvancedAuxiliaryInterfaces/IDiagnostics.vb b/AdvancedAuxiliaryInterfaces/IDiagnostics.vb
new file mode 100644
index 0000000000..e49348cf86
--- /dev/null
+++ b/AdvancedAuxiliaryInterfaces/IDiagnostics.vb
@@ -0,0 +1,21 @@
+Public Interface IDiagnostics
+
+
+
+Property AA_NonSmartAlternatorsEfficiency As single
+Property AA_SmartIdleCurrent_Amps As single
+Property AA_SmartIdleAlternatorsEfficiency As single
+Property AA_SmartTractionCurrent_Amps As single
+Property AA_SmartTractionAlternatorEfficiency As single
+Property AA_SmartOverrunCurrent_Amps As Single
+Property AA_SmartOverrunAlternatorEfficiency As Single
+Property AA_CompressorFlowRate_LitrePerSec As Single
+Property AA_OverrunFlag As integer
+Property AA_EngineIdleFlag As integer
+Property AA_CompressorFlag As integer
+Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams As single
+Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres As single
+
+
+
+End Interface
diff --git a/AdvancedAuxiliaryInterfaces/ISignals.vb b/AdvancedAuxiliaryInterfaces/ISignals.vb
index c5915c62fe..5bf418a0a7 100644
--- a/AdvancedAuxiliaryInterfaces/ISignals.vb
+++ b/AdvancedAuxiliaryInterfaces/ISignals.vb
@@ -8,6 +8,7 @@ Property ClutchEngaged As Boolean
Property EngineSpeed as integer
Property SmartPneumatics As Boolean
Property TotalCycleTimeSeconds As Integer
+Property CurrentCycleTimeInSeconds As Integer
property EngineDrivelineTorque as single
Property Idle As Boolean
Property InNeutral As Boolean
diff --git a/AdvancedAuxiliaryInterfaces/Signals.vb b/AdvancedAuxiliaryInterfaces/Signals.vb
index 58e1bf81b3..0292819415 100644
--- a/AdvancedAuxiliaryInterfaces/Signals.vb
+++ b/AdvancedAuxiliaryInterfaces/Signals.vb
@@ -36,6 +36,8 @@ Implements ISignals
Public Property TotalCycleTimeSeconds As Integer Implements ISignals.TotalCycleTimeSeconds
+ public Property CurrentCycleTimeInSeconds As Integer Implements ISignals.CurrentCycleTimeInSeconds
+
Public Property PreExistingAuxPower As Single Implements ISignals.PreExistingAuxPower
Public Property Idle As Boolean Implements ISignals.Idle
diff --git a/VECTO/GUI/F_VECTO.vb b/VECTO/GUI/F_VECTO.vb
index fd83f8f6f7..79d282aeca 100644
--- a/VECTO/GUI/F_VECTO.vb
+++ b/VECTO/GUI/F_VECTO.vb
@@ -1382,8 +1382,6 @@ Private Sub btnBrowseAAUXFile_Click( sender As Object, e As EventArgs) Handles
configResult=AAUX_Gobal.ConfigureAdvancedAuxiliaries(assembly.AssemblyName,assembly.AuxiliaryVersion,txtAdvancedAuxiliaryFile.Text,VECTOfile)
- dim a=2
-
else
'txtAdvancedAuxiliaryFile.Text="INVALIDFILENAME"
diff --git a/VECTO/MODcalc/cMOD.vb b/VECTO/MODcalc/cMOD.vb
index a9ae9034be..760dbf2598 100644
--- a/VECTO/MODcalc/cMOD.vb
+++ b/VECTO/MODcalc/cMOD.vb
@@ -40,6 +40,23 @@ Public Class cMOD
Public Pclutch As List(Of Single)
Public Grad As List(Of Single)
+ 'AA-TB
+ public AA_NonSmartAlternatorsEfficiency as List(Of single? )
+ public AA_SmartIdleCurrent_Amps as List(Of single? )
+ public AA_SmartIdleAlternatorsEfficiency as List(Of single? )
+ public AA_SmartTractionCurrent_Amps as List(Of single? )
+ public AA_SmartTractionAlternatorEfficiency as List(Of single? )
+ public AA_SmartOverrunCurrent_Amps as List(Of single? )
+ public AA_SmartOverrunAlternatorEfficiency as List(Of single? )
+ public AA_CompressorFlowRate_LitrePerSec as List(Of single? )
+ public AA_OverrunFlag as List(Of integer?)
+ public AA_EngineIdleFlag as List(Of integer?)
+ public AA_CompressorFlag as List(Of integer?)
+ public AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams as List(Of single? )
+ public AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres as List(Of single? )
+
+
+
Public EngState As List(Of tEngState)
'Vehicle
@@ -76,6 +93,23 @@ Public Class cMOD
Vh = New cVh
CylceKin = New cCycleKin
+
+ 'AA-TB
+ AA_NonSmartAlternatorsEfficiency = new List(Of single? )
+ AA_SmartIdleCurrent_Amps = new List(Of single? )
+ AA_SmartIdleAlternatorsEfficiency = new List(Of single? )
+ AA_SmartTractionCurrent_Amps = new List(Of single? )
+ AA_SmartTractionAlternatorEfficiency = new List(Of single? )
+ AA_SmartOverrunCurrent_Amps = new List(Of single? )
+ AA_SmartOverrunAlternatorEfficiency = new List(Of single? )
+ AA_CompressorFlowRate_LitrePerSec = new List(Of single? )
+ AA_OverrunFlag = new List(Of integer?)
+ AA_EngineIdleFlag = new List(Of integer?)
+ AA_CompressorFlag = new List(Of integer?)
+ AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams = new List(Of single? )
+ AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres = new List(Of single? )
+
+
Proll = New List(Of Single)
Psum = New List(Of Single)
Pstg = New List(Of Single)
diff --git a/VECTO/My Project/AssemblyInfo.vb b/VECTO/My Project/AssemblyInfo.vb
index 7cc99cef6e..5a475b633c 100644
--- a/VECTO/My Project/AssemblyInfo.vb
+++ b/VECTO/My Project/AssemblyInfo.vb
@@ -31,5 +31,5 @@ Imports System.Runtime.InteropServices
' by entering "*" in them:
' <Assembly: AssemblyVersion("1.0.*")>
-<Assembly: AssemblyVersion("2.0.4.0")>
-<Assembly: AssemblyFileVersion("2.0.4.0")>
+<Assembly: AssemblyVersion("2.1.4.0")>
+<Assembly: AssemblyFileVersion("2.1.4.0")>
diff --git a/VECTOAux/VectoAuxiliaries/AdvancedAuxiliaries.vb b/VECTOAux/VectoAuxiliaries/AdvancedAuxiliaries.vb
index f1f6233d96..425c6f0520 100644
--- a/VECTOAux/VectoAuxiliaries/AdvancedAuxiliaries.vb
+++ b/VECTOAux/VectoAuxiliaries/AdvancedAuxiliaries.vb
@@ -9,8 +9,11 @@ Public Class AdvancedAuxiliaries
Implements IAdvancedAuxiliaries
+
+
Private auxConfig As AuxiliaryConfig
+
'Supporting classes which may generate event messages
Private WithEvents compressorMap As ICompressorMap
Private Withevents alternatorMap As IAlternatorMap
@@ -60,6 +63,7 @@ Public Class AdvancedAuxiliaries
'Initialise Model
Public Sub Initialise( auxPath As String )
+ Signals.CurrentCycleTimeInSeconds=0
auxConfig = New AuxiliaryConfig(auxPath)
'Pass some signals from config to Signals. ( These are stored in the configuration but shared in the signal distribution around modules )
@@ -182,7 +186,11 @@ End Sub
M9.CycleStep( seconds )
M11.CycleStep( seconds )
+
+ 'Used in the fuel aggregated output on M13 ( Sum 5 )
+ Signals.CurrentCycleTimeInSeconds+=1
+ Return true
End Function
@@ -195,8 +203,10 @@ End Sub
Public Function RunStart( ByVal auxFilePath As String, ByRef message As String) As Boolean Implements VectoAuxiliaries.IAdvancedAuxiliaries.RunStart
- Initialise(auxFilePath)
- 'CycleStep( Signals.TotalCycleTimeSeconds, message)
+ Initialise(auxFilePath)
+
+ 'TODO:Modify Initialise to return a Bool.
+ Return true
End Function
@@ -277,6 +287,88 @@ End Sub
End Function
+ 'Diagnostic Signals
+
+ Public ReadOnly Property AA_NonSmartAlternatorsEfficiency As Single? Implements IAdvancedAuxiliaries.AA_NonSmartAlternatorsEfficiency
+ Get
+ Return M0.AlternatorsEfficiency
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_SmartIdleCurrent_Amps As Single? Implements IAdvancedAuxiliaries.AA_SmartIdleCurrent_Amps
+ Get
+ Return M05.SmartIdleCurrent
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_SmartIdleAlternatorsEfficiency As Single? Implements IAdvancedAuxiliaries.AA_SmartIdleAlternatorsEfficiency
+ Get
+ Return M05.AlternatorsEfficiencyIdleResultCard
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_SmartTractionCurrent_Amps As Single? Implements IAdvancedAuxiliaries.AA_SmartTractionCurrent_Amps
+ Get
+ Return M05.SmartTractionCurrent
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_SmartTractionAlternatorEfficiency As Single? Implements IAdvancedAuxiliaries.AA_SmartTractionAlternatorEfficiency
+ Get
+ Return AA_SmartTractionAlternatorEfficiency
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_SmartOverrunCurrent_Amps As Single? Implements IAdvancedAuxiliaries.AA_SmartOverrunCurrent_Amps
+ Get
+ Return M05.SmartOverrunCurrent
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_SmartOverrunAlternatorEfficiency As Single? Implements IAdvancedAuxiliaries.AA_SmartOverrunAlternatorEfficiency
+ Get
+ Return M05.AlternatorsEfficiencyOverrunResultCard
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_CompressorFlowRate_LitrePerSec As Single? Implements IAdvancedAuxiliaries.AA_CompressorFlowRate_LitrePerSec
+ Get
+ Return M4.GetAveragePowerDemandPerCompressorUnitFlowRate
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_OverrunFlag As Integer? Implements IAdvancedAuxiliaries.AA_OverrunFlag
+ Get
+ Return M6.OverrunFlag
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_EngineIdleFlag As Integer? Implements IAdvancedAuxiliaries.AA_EngineIdleFlag
+ Get
+ Return Signals.Idle
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_CompressorFlag As Integer? Implements IAdvancedAuxiliaries.AA_CompressorFlag
+ Get
+ Return M8.CompressorFlag
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams As Single? Implements IAdvancedAuxiliaries.AA_TotalCycleFC_BeforeSSandWHTCcorrection_Grams
+ Get
+ Return M13.TotalCycleFuelConsumptionGrams
+ End Get
+ End Property
+
+ Public ReadOnly Property AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres As Single? Implements IAdvancedAuxiliaries.AA_TotalCycleFC_BeforeSSandWHTCcorrection_Litres
+ Get
+ Return M13.TotalCycleFuelConsumptionLitres
+ End Get
+ End Property
+
+
+
End Class
diff --git a/VECTOAux/VectoAuxiliaries/DownstreamModules/IM13.vb b/VECTOAux/VectoAuxiliaries/DownstreamModules/IM13.vb
index 468fd273e3..561d43815c 100644
--- a/VECTOAux/VectoAuxiliaries/DownstreamModules/IM13.vb
+++ b/VECTOAux/VectoAuxiliaries/DownstreamModules/IM13.vb
@@ -1,7 +1,7 @@

-Imports AdvancedAuxiliaryInterfaces.Electrics
-Imports AdvancedAuxiliaryInterfaces.Pneumatics
-Imports AdvancedAuxiliaryInterfaces.Hvac
+Imports VectoAuxiliaries.Electrics
+Imports VectoAuxiliaries.Pneumatics
+Imports VectoAuxiliaries.Hvac
Namespace DownstreamModules
diff --git a/VECTOAux/VectoAuxiliaries/DownstreamModules/IM7.vb b/VECTOAux/VectoAuxiliaries/DownstreamModules/IM7.vb
index 57b30fefc4..c005492aae 100644
--- a/VECTOAux/VectoAuxiliaries/DownstreamModules/IM7.vb
+++ b/VECTOAux/VectoAuxiliaries/DownstreamModules/IM7.vb
@@ -1,7 +1,7 @@

-Imports AdvancedAuxiliaryInterfaces.Electrics
-Imports AdvancedAuxiliaryInterfaces.Pneumatics
-Imports AdvancedAuxiliaryInterfaces.Hvac
+Imports VectoAuxiliaries.Electrics
+Imports VectoAuxiliaries.Pneumatics
+Imports VectoAuxiliaries.Hvac
Namespace DownstreamModules
diff --git a/VECTOAux/VectoAuxiliaries/DownstreamModules/IM8.vb b/VECTOAux/VectoAuxiliaries/DownstreamModules/IM8.vb
index 7ace3cf64a..d3ee574cd0 100644
--- a/VECTOAux/VectoAuxiliaries/DownstreamModules/IM8.vb
+++ b/VECTOAux/VectoAuxiliaries/DownstreamModules/IM8.vb
@@ -1,7 +1,7 @@

-Imports AdvancedAuxiliaryInterfaces.Electrics
-Imports AdvancedAuxiliaryInterfaces.Pneumatics
-Imports AdvancedAuxiliaryInterfaces.Hvac
+Imports VectoAuxiliaries.Electrics
+Imports VectoAuxiliaries.Pneumatics
+Imports VectoAuxiliaries.Hvac
Namespace DownstreamModules
diff --git a/VECTOAux/VectoAuxiliaries/DownstreamModules/M13.vb b/VECTOAux/VectoAuxiliaries/DownstreamModules/M13.vb
index 2d6b5ffa3c..10542909a6 100644
--- a/VECTOAux/VectoAuxiliaries/DownstreamModules/M13.vb
+++ b/VECTOAux/VectoAuxiliaries/DownstreamModules/M13.vb
@@ -37,7 +37,7 @@ Private readonly Property Sum4 As Single
End Property
Private readonly Property Sum5 As Single
Get
- Return ( m1.HVACFuelingLitresPerHour * ( signals.TotalCycleTimeSeconds/3600)) * FUEL_DENSITY_L3
+ Return ( m1.HVACFuelingLitresPerHour * ( signals.CurrentCycleTimeInSeconds/3600)) * FUEL_DENSITY_L3
End Get
End Property
Private ReadOnly Property Sum6 As Single
diff --git a/VECTOAux/VectoAuxiliaries/Electrics/AlternatorMap.vb b/VECTOAux/VectoAuxiliaries/Electrics/AlternatorMap.vb
index b82b4409b7..98abb78c40 100644
--- a/VECTOAux/VectoAuxiliaries/Electrics/AlternatorMap.vb
+++ b/VECTOAux/VectoAuxiliaries/Electrics/AlternatorMap.vb
@@ -182,7 +182,7 @@ Implements IAlternatorMap
End Function
Public Function ReturnDefaultMapValueTests() As String
- Dim sb = New StringBuilder()
+ Dim sb As StringBuilder = New StringBuilder()
Dim x, y As Single
'All Sector Values
diff --git a/VECTOAux/VectoAuxiliaries/Electrics/ElectricsUserInputsConfig.vb b/VECTOAux/VectoAuxiliaries/Electrics/ElectricsUserInputsConfig.vb
index 8d16a7a5ad..cfaf018464 100644
--- a/VECTOAux/VectoAuxiliaries/Electrics/ElectricsUserInputsConfig.vb
+++ b/VECTOAux/VectoAuxiliaries/Electrics/ElectricsUserInputsConfig.vb
@@ -1,4 +1,4 @@
-Imports AdvancedAuxiliaryInterfaces.Electrics
+Imports VectoAuxiliaries.Electrics
Namespace Electrics
Public Class ElectricsUserInputsConfig
diff --git a/VECTOAux/VectoAuxiliaries/Electrics/IElectricsUserInputsConfig.vb b/VECTOAux/VectoAuxiliaries/Electrics/IElectricsUserInputsConfig.vb
index 7620c04951..300ce91a9d 100644
--- a/VECTOAux/VectoAuxiliaries/Electrics/IElectricsUserInputsConfig.vb
+++ b/VECTOAux/VectoAuxiliaries/Electrics/IElectricsUserInputsConfig.vb
@@ -1,4 +1,4 @@
-Imports AdvancedAuxiliaryInterfaces.Electrics
+Imports VectoAuxiliaries.Electrics
Namespace Electrics
diff --git a/VECTOAux/VectoAuxiliaries/Electrics/ResultCard.vb b/VECTOAux/VectoAuxiliaries/Electrics/ResultCard.vb
index 1fd66080b6..fb38c33c20 100644
--- a/VECTOAux/VectoAuxiliaries/Electrics/ResultCard.vb
+++ b/VECTOAux/VectoAuxiliaries/Electrics/ResultCard.vb
@@ -1,4 +1,4 @@
-Imports AdvancedAuxiliaryInterfaces.Electrics
+Imports VectoAuxiliaries.Electrics
Namespace Electrics
diff --git a/VECTOAux/VectoAuxiliaries/Pneumatics/M3_AveragePneumaticLoadDemand.vb b/VECTOAux/VectoAuxiliaries/Pneumatics/M3_AveragePneumaticLoadDemand.vb
index d194e20e67..0839f8c3c1 100644
--- a/VECTOAux/VectoAuxiliaries/Pneumatics/M3_AveragePneumaticLoadDemand.vb
+++ b/VECTOAux/VectoAuxiliaries/Pneumatics/M3_AveragePneumaticLoadDemand.vb
@@ -1,4 +1,4 @@
-Imports AdvancedAuxiliaryInterfaces.Pneumatics
+Imports VectoAuxiliaries.Pneumatics
Namespace Pneumatics
diff --git a/VECTOAux/VectoAuxiliaries/Pneumatics/M4_AirCompressor.vb b/VECTOAux/VectoAuxiliaries/Pneumatics/M4_AirCompressor.vb
index 77b2e56d80..d2d183751a 100644
--- a/VECTOAux/VectoAuxiliaries/Pneumatics/M4_AirCompressor.vb
+++ b/VECTOAux/VectoAuxiliaries/Pneumatics/M4_AirCompressor.vb
@@ -55,17 +55,8 @@ Namespace Pneumatics
End Set
End Property
- ''' <summary>
- ''' Creates a new instance of the AirCompressor Class
- ''' </summary>
- ''' <param name="map">map of compressor values against compressor rpm</param>
- ''' <remarks></remarks>
- 'Public Sub New(ByVal map As ICompressorMap, signals As ISignals)
- ' _map = map
- ' _signals = signals
- 'End Sub
- ''' <summary>
+ '''<summary>
''' Creates a new instance of the AirCompressor Class
''' </summary>
''' <param name="map">map of compressor values against compressor rpm</param>
diff --git a/VECTOAux/VectoAuxiliaries/UI/FB_Global.vb b/VECTOAux/VectoAuxiliaries/UI/FB_Global.vb
index 4d2c742060..2d9dbcea34 100644
--- a/VECTOAux/VectoAuxiliaries/UI/FB_Global.vb
+++ b/VECTOAux/VectoAuxiliaries/UI/FB_Global.vb
@@ -42,8 +42,8 @@ Module FB_Global
Public fbVMOD As cFileBrowser
'Paths
- private MyAppPath = My.Application.Info.DirectoryPath & "\"
- private MyConfPath = MyAppPath & "Config\"
+ private MyAppPath = My.Application.Info.DirectoryPath & "\"
+ private MyConfPath = MyAppPath & "Config\"
private MyDeclPath = MyAppPath & "Declaration\"
'private FB_FilHisDir = MyConfPath & "FileHistory\"
private HomePath As String = "<HOME>"
diff --git a/VECTOAux/VectoAuxiliaries/UI/frmAuxiliaryConfig.vb b/VECTOAux/VectoAuxiliaries/UI/frmAuxiliaryConfig.vb
index 9c9946ee1d..e5945053c0 100644
--- a/VECTOAux/VectoAuxiliaries/UI/frmAuxiliaryConfig.vb
+++ b/VECTOAux/VectoAuxiliaries/UI/frmAuxiliaryConfig.vb
@@ -307,7 +307,7 @@ Public Function IsZeroOrPostiveNumber(ByVal test As String) As Boolean
End Function
-Public Function IsNumberBetweenZeroandOne(test As String)
+Public Function IsNumberBetweenZeroandOne(test As String) As Boolean
'Is this numeric sanity check.
If Not IsNumeric(test) Then Return False
@@ -322,7 +322,7 @@ Public Function IsNumberBetweenZeroandOne(test As String)
End Function
-Public Function IsIntegerZeroOrPositiveNumber(test As String)
+Public Function IsIntegerZeroOrPositiveNumber(test As String) As Boolean
'Is this numeric sanity check.
If Not IsNumeric(test) Then Return False
@@ -1247,11 +1247,11 @@ Private Function GetSSMMAP( ByVal filePath As String , byref message As string)
catch ex As Exception
- Return Nothing
+ 'TODO:?
End Try
-
+ Return Nothing
End Function
diff --git a/VECTOAux/VectoAuxiliariesTests/Mocks/MockFuel50PC.vb b/VECTOAux/VectoAuxiliariesTests/Mocks/MockFuel50PC.vb
index de99ca603d..50ea62a8f8 100644
--- a/VECTOAux/VectoAuxiliariesTests/Mocks/MockFuel50PC.vb
+++ b/VECTOAux/VectoAuxiliariesTests/Mocks/MockFuel50PC.vb
@@ -23,30 +23,30 @@ Implements IFUELMAP
Public ReadOnly Property FC As List(Of Single) Implements IFUELMAP.FC
Get
-
+ Return New List(Of Single)
End Get
End Property
Public ReadOnly Property MapDim As Integer Implements IFUELMAP.MapDim
Get
-
+ Return 0
End Get
End Property
Public ReadOnly Property nU As List(Of Single) Implements IFUELMAP.nU
Get
-
+ Return New List(Of Single)
End Get
End Property
Public ReadOnly Property Tq As List(Of Single) Implements IFUELMAP.Tq
Get
-
+ Return New List(Of Single)
End Get
End Property
Public Function Triangulate() As Boolean Implements IFUELMAP.Triangulate
-
+ Return true
End Function
End Class
diff --git a/VECTOAux/VectoAuxiliariesTests/UnitTests/M13Tests.vb b/VECTOAux/VectoAuxiliariesTests/UnitTests/M13Tests.vb
index 285fc8ecaa..3da3a06291 100644
--- a/VECTOAux/VectoAuxiliariesTests/UnitTests/M13Tests.vb
+++ b/VECTOAux/VectoAuxiliariesTests/UnitTests/M13Tests.vb
@@ -41,7 +41,7 @@ Signals.Setup ( Function(x) x.SmartPneumatics)
Signals.Setup ( Function(x) x.SmartElectrics) .Returns( IP5 )
m1.Setup ( Function(x) x.HVACFuelingLitresPerHour) .Returns( IP6 )
Signals.Setup ( Function(x) x.TotalCycleTimeSeconds) .Returns( 3114)
-
+Signals.Setup ( Function(x) x.CurrentCycleTimeInSeconds) .Returns( 3114)
'Act
Dim target = New M13( m1.Object, m10.Object, M12.Object, Signals.Object)
--
GitLab