From 8b2e58d3a110efe52d6a9fcf13c57a8ebd6f146e Mon Sep 17 00:00:00 2001
From: Michael Krisper <michael.krisper@tugraz.at>
Date: Mon, 9 May 2016 12:34:38 +0200
Subject: [PATCH] updated todo comments (more uniform format) and removed some
(vair and beta input check)
---
.../VectoCore/InputData/FileIO/JSON/JSONGearboxData.cs | 2 +-
.../DataObjectAdaper/AbstractSimulationDataAdapter.cs | 2 +-
.../VectoCore/InputData/Reader/DrivingCycleDataReader.cs | 2 --
.../Models/SimulationComponent/Data/Gearbox/GearData.cs | 2 +-
.../Models/SimulationComponent/Impl/CombustionEngine.cs | 2 +-
.../SimulationComponent/Impl/DefaultDriverStrategy.cs | 2 +-
.../VectoCore/Models/SimulationComponent/Impl/Gearbox.cs | 2 +-
VectoCore/VectoCore/OutputData/IModalDataContainer.cs | 2 +-
.../Integration/SimulationRuns/FullPowertrain.cs | 7 +++----
9 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/VectoCore/VectoCore/InputData/FileIO/JSON/JSONGearboxData.cs b/VectoCore/VectoCore/InputData/FileIO/JSON/JSONGearboxData.cs
index c43592437d..37267ad5c7 100644
--- a/VectoCore/VectoCore/InputData/FileIO/JSON/JSONGearboxData.cs
+++ b/VectoCore/VectoCore/InputData/FileIO/JSON/JSONGearboxData.cs
@@ -185,7 +185,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.JSON
public virtual bool Enabled
{
- get { return false; // TODO @@@
+ get { return false; // TODO mk-2016-05-09: JSON ITorqueConverterInputData.Enabled always true --> as soon as TC is implemented, set to correct value!
}
}
diff --git a/VectoCore/VectoCore/InputData/Reader/DataObjectAdaper/AbstractSimulationDataAdapter.cs b/VectoCore/VectoCore/InputData/Reader/DataObjectAdaper/AbstractSimulationDataAdapter.cs
index 81a5721df3..1ec01546ad 100644
--- a/VectoCore/VectoCore/InputData/Reader/DataObjectAdaper/AbstractSimulationDataAdapter.cs
+++ b/VectoCore/VectoCore/InputData/Reader/DataObjectAdaper/AbstractSimulationDataAdapter.cs
@@ -164,7 +164,7 @@ namespace TUGraz.VectoCore.InputData.Reader.DataObjectAdaper
if (gearCurve == null) {
return engineCurve;
}
- // TODO MK-2016-04-18: also combine the curves at the intersection-points of line segments!
+ // TODO mk-2016-04-18: also combine the curves at the intersection-points of line segments!
var entries =
gearCurve.FullLoadEntries.Concat(engineCurve.FullLoadEntries)
.OrderBy(x => x.EngineSpeed)
diff --git a/VectoCore/VectoCore/InputData/Reader/DrivingCycleDataReader.cs b/VectoCore/VectoCore/InputData/Reader/DrivingCycleDataReader.cs
index 889ab1b3ea..7ddcaab7d6 100644
--- a/VectoCore/VectoCore/InputData/Reader/DrivingCycleDataReader.cs
+++ b/VectoCore/VectoCore/InputData/Reader/DrivingCycleDataReader.cs
@@ -538,7 +538,6 @@ namespace TUGraz.VectoCore.InputData.Reader
public static bool ValidateHeader(string[] header, bool throwExceptions = true)
{
- //todo mk-2016-02-15: check if vair_res, and vair_beta only when needed
var allowedCols = new[] {
Fields.Time,
Fields.VehicleSpeed,
@@ -586,7 +585,6 @@ namespace TUGraz.VectoCore.InputData.Reader
public static bool ValidateHeader(string[] header, bool throwExceptions = true)
{
- //todo mk-2016-02-15: check if vair_res, and vair_beta only when needed
var allowedCols = new[] {
Fields.Time,
Fields.VehicleSpeed,
diff --git a/VectoCore/VectoCore/Models/SimulationComponent/Data/Gearbox/GearData.cs b/VectoCore/VectoCore/Models/SimulationComponent/Data/Gearbox/GearData.cs
index 17a538f2cd..e864ad1198 100644
--- a/VectoCore/VectoCore/Models/SimulationComponent/Data/Gearbox/GearData.cs
+++ b/VectoCore/VectoCore/Models/SimulationComponent/Data/Gearbox/GearData.cs
@@ -48,7 +48,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Data.Gearbox
[Required, Range(double.Epsilon, 25)]
public double Ratio { get; internal set; }
- public bool TorqueConverterActive { get; internal set; } // TODO: think about refactoring...
+ public bool TorqueConverterActive { get; internal set; } // TODO mk-2016-05-09: Refactor TorqueConverterActive Flag when implementing Torque Converter
// public double AverageEfficiency { get; internal set; }
}
diff --git a/VectoCore/VectoCore/Models/SimulationComponent/Impl/CombustionEngine.cs b/VectoCore/VectoCore/Models/SimulationComponent/Impl/CombustionEngine.cs
index 5125e3db06..e6b30733af 100644
--- a/VectoCore/VectoCore/Models/SimulationComponent/Impl/CombustionEngine.cs
+++ b/VectoCore/VectoCore/Models/SimulationComponent/Impl/CombustionEngine.cs
@@ -337,7 +337,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
var fc = ModelData.ConsumptionMap.GetFuelConsumption(CurrentState.EngineTorque, avgEngineSpeed,
allowExtrapolation: (DataBus.ExecutionMode != ExecutionMode.Declaration));
- //todo (MK, 2015-11-11): calculate aux start stop correction when start stop functionality is implemented in v3
+ //TODO mk-2015-11-11: calculate aux start stop correction
var fcAux = fc;
var fcWHTC = fcAux * ModelData.WHTCCorrectionFactor;
diff --git a/VectoCore/VectoCore/Models/SimulationComponent/Impl/DefaultDriverStrategy.cs b/VectoCore/VectoCore/Models/SimulationComponent/Impl/DefaultDriverStrategy.cs
index e4534f04f7..ddcf7e0624 100644
--- a/VectoCore/VectoCore/Models/SimulationComponent/Impl/DefaultDriverStrategy.cs
+++ b/VectoCore/VectoCore/Models/SimulationComponent/Impl/DefaultDriverStrategy.cs
@@ -541,7 +541,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
Case<ResponseDrivingCycleDistanceExceeded>(r => {
if (!ds.IsEqual(r.MaxDistance)) {
// distance has been reduced due to vehicle stop in coast/roll action => use brake action to get exactly to the stop-distance
- // TODO: what if no gear is enaged (and we need driveline power to get to the stop-distance?
+ // TODO what if no gear is enaged (and we need driveline power to get to the stop-distance?
response = Driver.DrivingActionBrake(absTime, ds, DriverStrategy.BrakeTrigger.NextTargetSpeed, gradient);
}
}).
diff --git a/VectoCore/VectoCore/Models/SimulationComponent/Impl/Gearbox.cs b/VectoCore/VectoCore/Models/SimulationComponent/Impl/Gearbox.cs
index 227de3d7bd..ed204fb4fc 100644
--- a/VectoCore/VectoCore/Models/SimulationComponent/Impl/Gearbox.cs
+++ b/VectoCore/VectoCore/Models/SimulationComponent/Impl/Gearbox.cs
@@ -223,7 +223,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
}
IResponse retVal;
- // TODO: MQ 2016/03/10: investigate further the effects of having the condition angularvelocity != 0
+ // TODO MQ 2016/03/10: investigate further the effects of having the condition angularvelocity != 0
if (ClutchClosed(absTime) /* && !angularVelocity.IsEqual(0) */) {
retVal = RequestGearEngaged(absTime, dt, torque, angularVelocity, dryRun);
} else {
diff --git a/VectoCore/VectoCore/OutputData/IModalDataContainer.cs b/VectoCore/VectoCore/OutputData/IModalDataContainer.cs
index 116ebdd358..6163dc235e 100644
--- a/VectoCore/VectoCore/OutputData/IModalDataContainer.cs
+++ b/VectoCore/VectoCore/OutputData/IModalDataContainer.cs
@@ -233,7 +233,7 @@ namespace TUGraz.VectoCore.OutputData
public static WattSecond WorkTorqueConverter(this IModalDataContainer data)
{
- //TODO (MK, 2015-11-10): return torque converter work - this was currently not possible because torque converter is not implemented.
+ //TODO mk-2015-11-10: return torque converter work when TorqueConverter is implemented
return 0.SI<WattSecond>();
}
diff --git a/VectoCore/VectoCoreTest/Integration/SimulationRuns/FullPowertrain.cs b/VectoCore/VectoCoreTest/Integration/SimulationRuns/FullPowertrain.cs
index 36e7d39a00..43338df247 100644
--- a/VectoCore/VectoCoreTest/Integration/SimulationRuns/FullPowertrain.cs
+++ b/VectoCore/VectoCoreTest/Integration/SimulationRuns/FullPowertrain.cs
@@ -296,18 +296,17 @@ namespace TUGraz.VectoCore.Tests.Integration.SimulationRuns
@"TestData\job_1-Gear-Test-dist.vmod", testRowCount: false);
}
- // todo: add realistic FullLoadCurve
private static GearboxData CreateGearboxData()
{
var ratios = new[] { 6.38, 4.63, 3.44, 2.59, 1.86, 1.35, 1, 0.76 };
-
+
return new GearboxData {
Gears = ratios.Select((ratio, i) =>
Tuple.Create((uint)i,
new GearData {
+ // TODO mk-2016-05-09: add realistic FullLoadCurve for gearbox
FullLoadCurve = FullLoadCurveReader.ReadFromFile(GearboxFullLoadCurveFile),
- LossMap =
- TransmissionLossMap.ReadFromFile(GearboxLossMap, ratio, string.Format("Gear {0}", i)),
+ LossMap = TransmissionLossMap.ReadFromFile(GearboxLossMap, ratio, string.Format("Gear {0}", i)),
Ratio = ratio,
ShiftPolygon = ShiftPolygonReader.ReadFromFile(GearboxShiftPolygonFile)
}))
--
GitLab