From a4c60ac8ff2c0498d53f08cb88efab84da28bcb7 Mon Sep 17 00:00:00 2001
From: "Burns, Terry" <Terry.Burns@ricardo.com>
Date: Mon, 22 Sep 2014 10:30:40 +0000
Subject: [PATCH] UPDATED SEVERAL TESTS TO USE CONSTANTS AND RELATIVE PATHS.
These were failing as a result.
git-tfs-id: [http://tfs00.element.root.com:8080/tfs/TFSCollection]$/VECTO;C1614
---
VECTOAux/VectoAuxiliaries/Hvac/HVACMap.vb | 5 -----
.../Pneumatics/AirCompressor.vb | 10 +++++++++
.../VectoAuxiliariesTests/ClassDiagram1.cd | 2 ++
.../TestFiles/testCompressorMap.csv | 1 -
.../UnitTests/AirCompressorTests.vb | 4 +++-
.../UnitTests/AlternatorMapTests.vb | 13 ++++++++----
.../UnitTests/CompressorMapTests.vb | 21 +++++++++++++------
.../VectoAuxiliariesTests.vbproj | 1 +
8 files changed, 40 insertions(+), 17 deletions(-)
create mode 100644 VECTOAux/VectoAuxiliariesTests/ClassDiagram1.cd
diff --git a/VECTOAux/VectoAuxiliaries/Hvac/HVACMap.vb b/VECTOAux/VectoAuxiliaries/Hvac/HVACMap.vb
index d974bb6128..c915afbc62 100644
--- a/VECTOAux/VectoAuxiliaries/Hvac/HVACMap.vb
+++ b/VECTOAux/VectoAuxiliaries/Hvac/HVACMap.vb
@@ -7,8 +7,6 @@ Namespace Hvac
Public Class HVACMap
Implements IHVACMap
-
-
#Region "Header Comments"
'Some sort of multi-dimensional map implemented here
@@ -212,7 +210,6 @@ Namespace Hvac
End Sub
-
'Public Map Enquiry Methods
Public Function GetMapHeaders() As Dictionary(Of String, HVACMapParameter) Implements IHVACMap.GetMapHeaders
@@ -307,8 +304,6 @@ Namespace Hvac
End Function
-
-
End Class
End Namespace
\ No newline at end of file
diff --git a/VECTOAux/VectoAuxiliaries/Pneumatics/AirCompressor.vb b/VECTOAux/VectoAuxiliaries/Pneumatics/AirCompressor.vb
index 1b3e45e8e6..782986b407 100644
--- a/VECTOAux/VectoAuxiliaries/Pneumatics/AirCompressor.vb
+++ b/VECTOAux/VectoAuxiliaries/Pneumatics/AirCompressor.vb
@@ -1,6 +1,8 @@

Namespace Pneumatics
+
+
Public Class AirCompressor
Implements IAirCompressor
@@ -82,6 +84,13 @@ Namespace Pneumatics
Return _map.Initialise()
End Function
+ 'Queryable Compressor Methods
+ '
+ 'Compressor ( Speed ) Flow Rate
+ 'Power @ Crank From Pnumatics compressor off ( A )
+ 'Power @ Crank From Pnumatics compressor On ( B )
+ 'Power Delta ( A ) vs ( B )
+
''' <summary>
''' Returns the flow rate [litres/second] of compressor for the given engine rpm
''' </summary>
@@ -142,4 +151,5 @@ Namespace Pneumatics
End Function
End Class
+
End Namespace
\ No newline at end of file
diff --git a/VECTOAux/VectoAuxiliariesTests/ClassDiagram1.cd b/VECTOAux/VectoAuxiliariesTests/ClassDiagram1.cd
new file mode 100644
index 0000000000..7b894197b9
--- /dev/null
+++ b/VECTOAux/VectoAuxiliariesTests/ClassDiagram1.cd
@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="utf-8"?>
+<ClassDiagram />
\ No newline at end of file
diff --git a/VECTOAux/VectoAuxiliariesTests/TestFiles/testCompressorMap.csv b/VECTOAux/VectoAuxiliariesTests/TestFiles/testCompressorMap.csv
index 45f504e02e..d65941e1ba 100644
--- a/VECTOAux/VectoAuxiliariesTests/TestFiles/testCompressorMap.csv
+++ b/VECTOAux/VectoAuxiliariesTests/TestFiles/testCompressorMap.csv
@@ -2,6 +2,5 @@ rpm,flowRate [l/min],power [on] [kW],power [off] [kW]
100,200,2,1
200,400,4,2
300,600,6,3
-
400,800,8,4
500,1000,10,5
diff --git a/VECTOAux/VectoAuxiliariesTests/UnitTests/AirCompressorTests.vb b/VECTOAux/VectoAuxiliariesTests/UnitTests/AirCompressorTests.vb
index 474e26515a..94b9b277ec 100644
--- a/VECTOAux/VectoAuxiliariesTests/UnitTests/AirCompressorTests.vb
+++ b/VECTOAux/VectoAuxiliariesTests/UnitTests/AirCompressorTests.vb
@@ -4,7 +4,9 @@ Imports VectoAuxiliariesTests.Mocks
Namespace UnitTests
- <TestFixture()> Public Class AirCompressorTests
+ <TestFixture()>
+ <Category("Pnuematic - Compressor")>
+ Public Class AirCompressorTests
#Region "Test Constants"
Private Const GoodEfficiency As Single = 1
Private Const TooLowEfficiency As Single = 0.1
diff --git a/VECTOAux/VectoAuxiliariesTests/UnitTests/AlternatorMapTests.vb b/VECTOAux/VectoAuxiliariesTests/UnitTests/AlternatorMapTests.vb
index 0f9f2e5aeb..454e49556c 100644
--- a/VECTOAux/VectoAuxiliariesTests/UnitTests/AlternatorMapTests.vb
+++ b/VECTOAux/VectoAuxiliariesTests/UnitTests/AlternatorMapTests.vb
@@ -7,6 +7,11 @@ Namespace UnitTests
<TestFixture()>
Public Class AlternatorMapTests
+ Private Const _GOODMAP As String = "TestFiles\testAlternatorMap.csv"
+ Private Const _INVALIDRPMMAP As String = "TestFiles\testAlternatorMapWithInvalidRpm.csv"
+ Private Const _IVALIDEFFICIENCYMAP As String = "TestFiles\testAlternatorMapWithInvalidEfficiency.csv"
+ Private Const _INVALIDPOWERMAP As String = "TestFiles\testAlternatorMapWithInvalidPower.csv"
+
<Test()>
Public Sub CreateNewAlternatorMapInstanceTest()
Dim path As String = "test"
@@ -46,21 +51,21 @@ Namespace UnitTests
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialiseInvalidRpmThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testAlternatorMapWithInvalidRpm.csv"
+ Dim path As String = _INVALIDRPMMAP
Dim target As AlternatorMap = New AlternatorMap(path)
target.Initialise()
End Sub
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialiseInvalidEfficiencyThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testAlternatorMapWithInvalidEfficiency.csv"
+ Dim path As String = _IVALIDEFFICIENCYMAP
Dim target As AlternatorMap = New AlternatorMap(path)
target.Initialise()
End Sub
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialiseInvalidPowerThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testAlternatorMapWithInvalidPower.csv"
+ Dim path As String = _INVALIDPOWERMAP
Dim target As AlternatorMap = New AlternatorMap(path)
target.Initialise()
End Sub
@@ -138,7 +143,7 @@ Namespace UnitTests
End Function
Private Function GetMap() As AlternatorMap
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testAlternatorMap.csv"
+ Dim path As String = _GOODMAP
Dim target As AlternatorMap = New AlternatorMap(path)
Return target
End Function
diff --git a/VECTOAux/VectoAuxiliariesTests/UnitTests/CompressorMapTests.vb b/VECTOAux/VectoAuxiliariesTests/UnitTests/CompressorMapTests.vb
index 2b9d1280e8..d0f7beb0f6 100644
--- a/VECTOAux/VectoAuxiliariesTests/UnitTests/CompressorMapTests.vb
+++ b/VECTOAux/VectoAuxiliariesTests/UnitTests/CompressorMapTests.vb
@@ -6,6 +6,14 @@ Namespace UnitTests
<TestFixture()>
Public Class CompressorMapTests
+ Private Const GOODMAP As String = "TestFiles\testCompressorMap.csv"
+ Private Const INVALIDPOWERCOMPRESSORONMAP As String = "TestFiles\testCompressorMapInvalidOnPower.csv"
+ Private Const INVALIDPOWERCOMPRESSOROFFMAP As String = "TestFiles\testCompressorMapInvalidOffPower.csv"
+ Private Const INVALIDFLOWRATEMAP As String = "TestFiles\testCompressorMapInvalidFlow.csv"
+ Private Const INSSUFICIENTROWSMAP As String = "TestFiles\testCompressorMapNotEnoughRows.csv"
+ Private Const INVALIDRPMMAP As String = "TestFiles\testCompressorMapInvalidRpm.csv"
+
+
#Region "Helpers"
Private Function GetInitialiseMap() As CompressorMap
@@ -15,7 +23,7 @@ Namespace UnitTests
End Function
Private Function GetMap() As CompressorMap
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testCompressorMap.csv"
+ Dim path As String = GOODMAP
Dim target As CompressorMap = New CompressorMap(path)
Return target
End Function
@@ -51,35 +59,35 @@ Namespace UnitTests
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialisationInvalidRpmThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testCompressorMapInvalidRpm.csv"
+ Dim path As String = INVALIDRPMMAP
Dim target As CompressorMap = New CompressorMap(path)
target.Initialise()
End Sub
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialisationInvalidFlowRateThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testCompressorMapInvalidFlow.csv"
+ Dim path As String = INVALIDFLOWRATEMAP
Dim target As CompressorMap = New CompressorMap(path)
target.Initialise()
End Sub
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialisationInvalidPowerCompressorOnThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testCompressorMapInvalidOnPower.csv"
+ Dim path As String = INVALIDPOWERCOMPRESSORONMAP
Dim target As CompressorMap = New CompressorMap(path)
target.Initialise()
End Sub
<Test(), ExpectedException("System.InvalidCastException")>
Public Sub InitialisationInvalidPowerCompressorOffThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testCompressorMapInvalidOffPower.csv"
+ Dim path As String = INVALIDPOWERCOMPRESSOROFFMAP
Dim target As CompressorMap = New CompressorMap(path)
target.Initialise()
End Sub
<Test(), ExpectedException("System.ArgumentException")>
Public Sub InitialisationInsufficientRowsThrowsExceptionTest()
- Dim path As String = "C:\DEV\VECTO\VectoAuxiliaries\VectoAuxiliariesTests\TestFiles\testCompressorMapNotEnoughRows.csv"
+ Dim path As String = INSSUFICIENTROWSMAP
Dim target As CompressorMap = New CompressorMap(path)
target.Initialise()
End Sub
@@ -160,4 +168,5 @@ Namespace UnitTests
End Sub
End Class
+
End Namespace
\ No newline at end of file
diff --git a/VECTOAux/VectoAuxiliariesTests/VectoAuxiliariesTests.vbproj b/VECTOAux/VectoAuxiliariesTests/VectoAuxiliariesTests.vbproj
index 99cf5a5de0..99df40ff9a 100644
--- a/VECTOAux/VectoAuxiliariesTests/VectoAuxiliariesTests.vbproj
+++ b/VECTOAux/VectoAuxiliariesTests/VectoAuxiliariesTests.vbproj
@@ -126,6 +126,7 @@
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
+ <None Include="ClassDiagram1.cd" />
<None Include="My Project\Application.myapp">
<Generator>MyApplicationCodeGenerator</Generator>
<LastGenOutput>Application.Designer.vb</LastGenOutput>
--
GitLab