From c8243be970bc8e329cc62140032420429679d192 Mon Sep 17 00:00:00 2001 From: Markus Quaritsch <markus.quaritsch@tugraz.at> Date: Thu, 27 Apr 2017 10:05:26 +0200 Subject: [PATCH] more explicit exception texts --- .../XML/Declaration/XMLDeclarationGearboxDataProvider.cs | 8 +++----- .../XML/Declaration/XMLDeclarationVehicleDataProvider.cs | 8 +++----- VectoCore/VectoCore/OutputData/XML/AbstractXMLWriter.cs | 4 ++-- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationGearboxDataProvider.cs b/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationGearboxDataProvider.cs index f28629011d..735cecee61 100644 --- a/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationGearboxDataProvider.cs +++ b/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationGearboxDataProvider.cs @@ -23,8 +23,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.XML.Declaration public GearboxType Type { - get - { + get { var value = GetElementValue(XMLNames.Gearbox_TransmissionType); switch (value) { case "MT": @@ -36,14 +35,13 @@ namespace TUGraz.VectoCore.InputData.FileIO.XML.Declaration case "AT - PowerSplit": return GearboxType.ATPowerSplit; } - throw new ArgumentOutOfRangeException(value); + throw new ArgumentOutOfRangeException("GearboxType", value); } } public IList<ITransmissionInputData> Gears { - get - { + get { var retVal = new List<ITransmissionInputData>(); var gears = Navigator.Select( Helper.Query(XBasePath, XMLNames.Gearbox_Gears, XMLNames.Gearbox_Gears_Gear), diff --git a/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationVehicleDataProvider.cs b/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationVehicleDataProvider.cs index 35ee3528fd..e1b4ab9412 100644 --- a/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationVehicleDataProvider.cs +++ b/VectoCore/VectoCore/InputData/FileIO/XML/Declaration/XMLDeclarationVehicleDataProvider.cs @@ -48,8 +48,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.XML.Declaration public IList<IAxleDeclarationInputData> Axles { - get - { + get { var axles = Navigator.Select(Helper.Query(VehiclePath, XMLNames.Vehicle_Components, XMLNames.Component_AxleWheels, XMLNames.ComponentDataWrapper, XMLNames.AxleWheels_Axles, XMLNames.AxleWheels_Axles_Axle), Manager); @@ -85,8 +84,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.XML.Declaration public RetarderType RetarderType { - get - { + get { var value = GetElementValue(XMLNames.Vehicle_RetarderType); //.ParseEnum<RetarderType>(); switch (value) { case "None": @@ -100,7 +98,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.XML.Declaration case "Transmission Output Retarder": return RetarderType.TransmissionOutputRetarder; } - throw new ArgumentOutOfRangeException(value); + throw new ArgumentOutOfRangeException("RetarderType", value); } } diff --git a/VectoCore/VectoCore/OutputData/XML/AbstractXMLWriter.cs b/VectoCore/VectoCore/OutputData/XML/AbstractXMLWriter.cs index de3be434e8..efd437645e 100644 --- a/VectoCore/VectoCore/OutputData/XML/AbstractXMLWriter.cs +++ b/VectoCore/VectoCore/OutputData/XML/AbstractXMLWriter.cs @@ -81,7 +81,7 @@ namespace TUGraz.IVT.VectoXML.Writer case CrossWindCorrectionMode.DeclarationModeCorrection: return "Declaration Mode Correction"; default: - throw new ArgumentOutOfRangeException("mode", mode, null); + throw new ArgumentOutOfRangeException("CrosswindCorrection", mode, null); } } @@ -99,7 +99,7 @@ namespace TUGraz.IVT.VectoXML.Writer case RetarderType.LossesIncludedInTransmission: return "Losses included in Gearbox"; default: - throw new ArgumentOutOfRangeException("retarder", type, null); + throw new ArgumentOutOfRangeException("RetarderType", type, null); } } -- GitLab