From 5538fdf4f0164b4c3b2a12849292e8a6d40d4cf3 Mon Sep 17 00:00:00 2001
From: RIHTARSIC Joze <joze.rihtarsic@ext.ec.europa.eu>
Date: Wed, 12 Jun 2024 16:59:57 +0200
Subject: [PATCH] Fix sonar plans issues
---
.../src/main/java/eu/europa/ec/smp/spi/utils/DomUtils.java | 2 +-
.../europa/ec/edelivery/smp/ui/edit/DomainEditController.java | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/smp-spi/src/main/java/eu/europa/ec/smp/spi/utils/DomUtils.java b/smp-spi/src/main/java/eu/europa/ec/smp/spi/utils/DomUtils.java
index 4eb543da8..39c67d2ab 100644
--- a/smp-spi/src/main/java/eu/europa/ec/smp/spi/utils/DomUtils.java
+++ b/smp-spi/src/main/java/eu/europa/ec/smp/spi/utils/DomUtils.java
@@ -126,10 +126,10 @@ public final class DomUtils {
*/
public static Transformer createNewSecureTransformer() throws TransformerConfigurationException {
TransformerFactory factory = TransformerFactory.newInstance();
+ factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
// generic secure file processing
setConfigurationOption(factory, XMLInputFactory.SUPPORT_DTD, false);
setConfigurationOption(factory, XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, Boolean.FALSE);
- setConfigurationOption(factory, XMLConstants.FEATURE_SECURE_PROCESSING, true);
setConfigurationOption(factory, DISALLOW_DOCTYPE_FEATURE, true);
setAttributeOption(factory, XMLConstants.ACCESS_EXTERNAL_DTD, "");
setAttributeOption(factory, XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");
diff --git a/smp-webapp/src/main/java/eu/europa/ec/edelivery/smp/ui/edit/DomainEditController.java b/smp-webapp/src/main/java/eu/europa/ec/edelivery/smp/ui/edit/DomainEditController.java
index 48af60e66..3b3cf2e7c 100644
--- a/smp-webapp/src/main/java/eu/europa/ec/edelivery/smp/ui/edit/DomainEditController.java
+++ b/smp-webapp/src/main/java/eu/europa/ec/edelivery/smp/ui/edit/DomainEditController.java
@@ -198,10 +198,6 @@ public class DomainEditController {
if (propertyRO == null || StringUtils.isBlank(propertyRO.getProperty())) {
throw new SMPRuntimeException(ErrorCode.INVALID_REQUEST, "ValidateProperty", "Property name is empty!");
}
- SMPDomainPropertyEnum.getByProperty(propertyRO.getProperty())
- .orElseThrow(() -> new SMPRuntimeException(ErrorCode.INVALID_REQUEST,
- "ValidateProperty", "Property [" + propertyRO.getProperty() + "] is not domain property!"));
-
return uiDomainEditService.validateDomainProperty(propertyRO);
}
--
GitLab