From a0088dcec790ef26e04f01790718b4f27c9f74bd Mon Sep 17 00:00:00 2001
From: Joze RIHTARSIC <joze.rihtarsic@ext.ec.europa.eu>
Date: Thu, 6 Dec 2018 13:59:00 +0100
Subject: [PATCH] sonar code coverage issue
---
.../smp/sml/SmlConnectorTestDomain.java | 191 ------------------
1 file changed, 191 deletions(-)
delete mode 100644 smp-server-library/src/test/java/eu/europa/ec/edelivery/smp/sml/SmlConnectorTestDomain.java
diff --git a/smp-server-library/src/test/java/eu/europa/ec/edelivery/smp/sml/SmlConnectorTestDomain.java b/smp-server-library/src/test/java/eu/europa/ec/edelivery/smp/sml/SmlConnectorTestDomain.java
deleted file mode 100644
index e807d73eb..000000000
--- a/smp-server-library/src/test/java/eu/europa/ec/edelivery/smp/sml/SmlConnectorTestDomain.java
+++ /dev/null
@@ -1,191 +0,0 @@
-/*
- * Copyright 2018 European Commission | CEF eDelivery
- *
- * Licensed under the EUPL, Version 1.2 or - as soon they will be approved by the European Commission - subsequent versions of the EUPL (the "Licence");
- * You may not use this work except in compliance with the Licence.
- *
- * You may obtain a copy of the Licence attached in file: LICENCE-EUPL-v1.2.pdf
- *
- * Unless required by applicable law or agreed to in writing, software distributed under the Licence is distributed on an "AS IS" basis,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the Licence for the specific language governing permissions and limitations under the Licence.
- */
-
-package eu.europa.ec.edelivery.smp.sml;
-
-import eu.europa.ec.bdmsl.ws.soap.BadRequestFault;
-import eu.europa.ec.bdmsl.ws.soap.InternalErrorFault;
-import eu.europa.ec.bdmsl.ws.soap.NotFoundFault;
-import eu.europa.ec.bdmsl.ws.soap.UnauthorizedFault;
-import eu.europa.ec.edelivery.smp.config.ConversionTestConfig;
-import eu.europa.ec.edelivery.smp.config.PropertiesSingleDomainTestConfig;
-import eu.europa.ec.edelivery.smp.config.SmlIntegrationConfiguration;
-import eu.europa.ec.edelivery.smp.exceptions.SMPRuntimeException;
-import eu.europa.ec.edelivery.smp.services.SecurityUtilsServices;
-import eu.europa.ec.edelivery.smp.services.ui.UIKeystoreService;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-import org.junit.runner.RunWith;
-import org.mockito.Mockito;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.TestPropertySource;
-import org.springframework.test.context.junit4.SpringRunner;
-
-import static eu.europa.ec.edelivery.smp.sml.SmlConnectorTestConstants.*;
-import static org.junit.Assert.*;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.Mockito.verify;
-
-/**
- * Created by JRC
- * since 4.1.
- */
-@RunWith(SpringRunner.class)
-@ContextConfiguration(classes = {SmlConnector.class, SmlIntegrationConfiguration.class,
- SecurityUtilsServices.class, UIKeystoreService.class,
- ConversionTestConfig.class, PropertiesSingleDomainTestConfig.class})
-@TestPropertySource(properties = {
- "bdmsl.integration.enabled=true"})
-public class SmlConnectorTestDomain {
-
- @Rule
- public ExpectedException expectedExeption = ExpectedException.none();
-
- @Autowired
- protected SmlConnector smlConnector;
- @Autowired
- SmlIntegrationConfiguration mockSml;
-
- @Before
- public void setup() {
- mockSml.reset();
- }
-
- @Test
- public void testRegisterDomainInDns() throws UnauthorizedFault, InternalErrorFault, BadRequestFault {
- //when
-
- boolean result = smlConnector.registerDomain(DEFAULT_DOMAIN);
-
- //then
- assertTrue(result);
- assertEquals(1, mockSml.getSmpManagerClientMocks().size());
- verify(mockSml.getSmpManagerClientMocks().get(0)).create(any());
- Mockito.verifyNoMoreInteractions(mockSml.getSmpManagerClientMocks().toArray());
- }
-
- @Test
- public void testRegisterDomainInDnsAlreadyExists() throws UnauthorizedFault, InternalErrorFault, BadRequestFault {
- //when
- BadRequestFault ex = new BadRequestFault(ERROR_SMP_ALREADY_EXISTS);
- mockSml.setThrowException(ex);
- boolean result = smlConnector.registerDomain(DEFAULT_DOMAIN);
-
- //then
- assertTrue(result);
- assertEquals(1, mockSml.getSmpManagerClientMocks().size());
- verify(mockSml.getSmpManagerClientMocks().get(0)).create(any());
- Mockito.verifyNoMoreInteractions(mockSml.getSmpManagerClientMocks().toArray());
- }
-
- @Test
- public void testRegisterDomainInDnsUnknownException() {
- //when
- String message = "something unexpected";
- Exception ex = new Exception(message);
- mockSml.setThrowException(ex);
- expectedExeption.expectMessage(message);
- expectedExeption.expect(SMPRuntimeException.class);
-
- smlConnector.registerDomain(DEFAULT_DOMAIN);
- }
-
- @Test
- public void testRegisterDomainInDnsNewClientIsAlwaysCreated() throws UnauthorizedFault, NotFoundFault, InternalErrorFault, BadRequestFault {
- //when
- smlConnector.registerDomain(DEFAULT_DOMAIN);
- smlConnector.registerDomain(DEFAULT_DOMAIN);
-
- //then
- assertEquals(2, mockSml.getSmpManagerClientMocks().size());
- verify(mockSml.getSmpManagerClientMocks().get(0)).create(any());
- verify(mockSml.getSmpManagerClientMocks().get(1)).create(any());
- Mockito.verifyNoMoreInteractions(mockSml.getSmpManagerClientMocks().toArray());
- }
-
- @Test
- public void testDomainUnregisterFromDns() throws UnauthorizedFault, NotFoundFault, InternalErrorFault, BadRequestFault {
- //when
- boolean result = smlConnector.unregisterDomain(DEFAULT_DOMAIN);
-
- //then
- assertTrue(result);
- assertEquals(1, mockSml.getSmpManagerClientMocks().size());
- verify(mockSml.getSmpManagerClientMocks().get(0)).delete(any());
- Mockito.verifyNoMoreInteractions(mockSml.getSmpManagerClientMocks().toArray());
- }
-
- @Test
- public void testUnregisterDomainFromDnsNewClientIsAlwaysCreated() throws UnauthorizedFault, NotFoundFault, InternalErrorFault, BadRequestFault {
- //when
- smlConnector.unregisterDomain(DEFAULT_DOMAIN);
- smlConnector.unregisterDomain(DEFAULT_DOMAIN);
-
- //then
- assertEquals(2, mockSml.getSmpManagerClientMocks().size());
- verify(mockSml.getSmpManagerClientMocks().get(0)).delete(any());
- verify(mockSml.getSmpManagerClientMocks().get(1)).delete(any());
- Mockito.verifyNoMoreInteractions(mockSml.getSmpManagerClientMocks().toArray());
- }
-
- @Test
- public void testUnregisterDomainFromDnsThrowUnknownBadRequestFault() {
- //when
- BadRequestFault ex = new BadRequestFault(ERROR_UNEXPECTED_MESSAGE);
- mockSml.setThrowException(ex);
- expectedExeption.expectMessage(ERROR_UNEXPECTED_MESSAGE);
- expectedExeption.expect(SMPRuntimeException.class);
-
- smlConnector.unregisterDomain(DEFAULT_DOMAIN);
- }
-
- @Test
- public void testUnregisterDomainFromDnsThrowUnknownException() {
- //when
- String message = "something unexpected";
- Exception ex = new Exception(message);
- mockSml.setThrowException(ex);
- expectedExeption.expectMessage(message);
- expectedExeption.expect(SMPRuntimeException.class);
-
- smlConnector.unregisterDomain(DEFAULT_DOMAIN);
- }
-
- @Test
- public void testUnregisterDomainFromDnsNotExists() {
- //when
- BadRequestFault ex = new BadRequestFault(ERROR_SMP_NOT_EXISTS);
- mockSml.setThrowException(ex);
- boolean suc = smlConnector.unregisterDomain(DEFAULT_DOMAIN);
-
- assertTrue(suc);
- }
-
- @Test
- public void testIsOkMessageForDomainNull() {
- boolean suc = smlConnector.isOkMessage(DEFAULT_DOMAIN, null);
-
- assertFalse(suc);
- }
-
- @Test
- public void testIsOkMessageForDomainFalse() {
-
- boolean suc = smlConnector.isOkMessage(DEFAULT_DOMAIN, ERROR_UNEXPECTED_MESSAGE);
-
- assertFalse(suc);
- }
-}
--
GitLab