Fix Ansible lint warnings and errors

ansible/build.yml

@@ -31,7 +31,7 @@
         source: build
 
     - name: Get source image
-      set_fact:
+      ansible.builtin.set_fact:
         source_image: "{{ lookup('ansible.builtin.file', '../Dockerfile') | regex_search('FROM (.*):(.*)') | regex_replace('^FROM\\s(.*)$', '\\1') }}"
 
     - name: Remove local image
@@ -56,6 +56,6 @@
       community.docker.docker_login:
         state: absent
 
-    - name: debug
-      debug:
+    - name: Debug
+      ansible.builtin.debug:
         msg: "{{ lookup('ansible.builtin.env', 'CI_REGISTRY_IMAGE') }}:{{ lookup('ansible.builtin.env', 'CI_COMMIT_SHORT_SHA') }}"

ansible/deploy_on_test.yml

@@ -6,21 +6,25 @@
       ansible.builtin.file:
         path: "/home/debian/netbox/{{ lookup('ansible.builtin.env', 'CI_PIPELINE_ID') }}"
         state: directory
+        mode: "0755"
 
     - name: Copy docker-compose file
       ansible.builtin.copy:
         src: "../docker-compose.yml"
         dest: "/home/debian/netbox/{{ lookup('ansible.builtin.env', 'CI_PIPELINE_ID') }}/docker-compose.yml"
+        mode: "0644"
 
     - name: Copy testing docker-compose file
       ansible.builtin.copy:
         src: "../docker-compose.test.yml"
         dest: "/home/debian/netbox/{{ lookup('ansible.builtin.env', 'CI_PIPELINE_ID') }}/docker-compose.override.yml"
+        mode: "0644"
 
     - name: Copy testing env variables
       ansible.builtin.copy:
         src: "../env"
         dest: "/home/debian/netbox/{{ lookup('ansible.builtin.env', 'CI_PIPELINE_ID') }}/"
+        mode: "0755"
 
     - name: Create .env file
       ansible.builtin.copy:
@@ -40,7 +44,7 @@
         url: "http://{{ lookup('ansible.builtin.env', 'CI_COMMIT_SHORT_SHA') }}.{{ lookup('ansible.builtin.env', 'HOSTNAME') }}/metrics"
         status_code: 200
       register: curl_output
-      until: curl_output.status  == 200
+      until: curl_output.status == 200
       retries: 60
       delay: 5
       delegate_to: localhost

docker-compose.prod.yml

@@ -30,4 +30,3 @@ volumes:
         driver: local
     netbox-scripts-files:
         driver: local
-

docker-compose.test.yml

@@ -3,19 +3,19 @@ services:
     netbox:
         image: "code.europa.eu:4567/digit-c4/netbox-plugins:${TAG}"
         ports:
-          - 8080
+            - 8080
         healthcheck:
             start_period: 2s
             retries: 30
         env_file: env/netbox.env
         environment:
-          - DB_HOST=postgres_${TAG}
-          - REDIS_CACHE_HOST=redis_cache_${TAG}
-          - REDIS_HOST=redis_${TAG}
+            - DB_HOST=postgres_${TAG}
+            - REDIS_CACHE_HOST=redis_cache_${TAG}
+            - REDIS_HOST=redis_${TAG}
         labels:
-          - "traefik.http.routers.netbox-${TAG}.rule=Host(`${TAG}.netbox.ntx.lu`)"
+            - "traefik.http.routers.netbox-${TAG}.rule=Host(`${TAG}.netbox.ntx.lu`)"
         networks:
-          - traefik
+            - traefik
         logging:
             driver: "syslog"
             options:
@@ -26,7 +26,7 @@ services:
         image: "code.europa.eu:4567/digit-c4/netbox-plugins:${TAG}"
         env_file: env/netbox.env
         networks:
-          - traefik
+            - traefik
         logging:
             driver: "syslog"
             options:
@@ -37,7 +37,7 @@ services:
         image: "code.europa.eu:4567/digit-c4/netbox-plugins:${TAG}"
         env_file: env/netbox.env
         networks:
-          - traefik
+            - traefik
         logging:
             driver: "syslog"
             options:
@@ -48,7 +48,7 @@ services:
         container_name: postgres_${TAG}
         env_file: env/postgres.env
         networks:
-          - traefik
+            - traefik
         logging:
             driver: "syslog"
             options:
@@ -59,7 +59,7 @@ services:
         container_name: redis_${TAG}
         env_file: env/redis.env
         networks:
-          - traefik
+            - traefik
         logging:
             driver: "syslog"
             options:
@@ -70,7 +70,7 @@ services:
         container_name: redis_cache_${TAG}
         env_file: env/redis-cache.env
         networks:
-          - traefik
+            - traefik
         logging:
             driver: "syslog"
             options: