Various fixes for new mapping properties in form, change client_max_body_size...

Various fixes for new mapping properties in form, change client_max_body_size value for futurproofness and add properties tests

requested review from @veniela and @politgu

assigned to @simovin

@n00aamxt We fix lint warning. We create this PR in place of !60 (closed). Can you review this PR?

approved this merge request

unapproved this merge request

Hello @simovin,

I apology for the late answer, as I joined the EC, this is my new GitLab account. The changes seem good to me, however I still see some failing tests because of the error A mapping with this source already exists.

Do you know the root cause of this? Is it blocking?

Best regards, Anthony GRAF

Hello @grafant ,

This means this Mapping already exist when you whant to create it. You can delete mapping you create right after the test.

Hello @simovin

I noticed an issue with the model for the default value for the proxy_max_temp_file_size that has the default value of 1 instead of 1024. Also, instruction self.mapping_id = json.loads(response.content)["id"] is missing in some of the methods in class TestMappingPropertiesValidation in netbox-plugins/plugins/netbox-rps-plugin/tests/e2e/test_mapping_properties_validation.py To avoid creation a new fork of this repo (as I'm not allowed to push directly on the current branch), would it be possible for you to make a new commit with those changes? Thanks a lot

Best regards, Anthony

Hello @simovin,

Any news about this?

Best regards, Anthony

closed