add more validations

netbox_sys_plugin/tests/createvm/test_createvm_view.py

@@ -81,9 +81,9 @@ class CreateVmFormTestCase(TestCase):
     def test_invalid_form(self):
         """Test a valid form submission."""
 
-        #invalid json
+        #invalid domain names json
         self.invalid_ports_form_data = self.form_data_template.copy()
-        self.invalid_ports_form_data["domainnames_new-domain_names"] = "Invalid"  # Invalid format
+        self.invalid_ports_form_data["domainnames_new-domain_names"] = "Invalid"  # Invalid Json
 
         form_data = self.invalid_ports_form_data
         form = CreateVmForm(data=form_data)
@@ -91,6 +91,17 @@ class CreateVmFormTestCase(TestCase):
             form.process_creation(form_data)
         self.assertIn(
             "Invalid JSON format: Please provide a valid JSON object.", str(context.exception))
+        
+        #invalid structure
+        self.invalid_ports_form_data = self.form_data_template.copy()
+        self.invalid_ports_form_data["vmassignedextraconfig_new-extra_config_values"] = '{"field1": 1}'  # Invalid Structure
+
+        form_data = self.invalid_ports_form_data
+        form = CreateVmForm(data=form_data)
+        with self.assertRaises(ValueError) as context:
+            form.process_creation(form_data)
+        self.assertIn(
+            "Missing or empty required field: \'field1\' with type string", str(context.exception))
 
         #black ports
         self.invalid_ports_form_data = self.form_data_template.copy()
@@ -131,10 +142,20 @@ class CreateVmFormTestCase(TestCase):
             form.process_creation(form_data)
         self.assertIn(
             "Error during creation: Invalid Device Role ID", str(context.exception))
+        
+        #blank role/owner
+        self.invalid_ports_form_data = self.form_data_template.copy()
+        self.invalid_ports_form_data["vms_new-0-role"] = ""  # Invalid format
+        form_data = self.invalid_ports_form_data
+        form = CreateVmForm(data=form_data)
+        with self.assertRaises(ValueError) as context:
+            form.process_creation(form_data)
+        self.assertIn(
+            "Owner cannot be empty", str(context.exception))
 
         #invalid platform
         self.invalid_ports_form_data = self.form_data_template.copy()
-        self.invalid_ports_form_data["vms_new-0-platform"] = "2"  # Invalid format
+        self.invalid_ports_form_data["vms_new-0-platform"] = "2"  # Invalid id
         form_data = self.invalid_ports_form_data
         form = CreateVmForm(data=form_data)
         with self.assertRaises(ValueError) as context:
@@ -142,6 +163,26 @@ class CreateVmFormTestCase(TestCase):
         self.assertIn(
             "Invalid Platform ID", str(context.exception))
 
+        #blank platform
+        self.invalid_ports_form_data = self.form_data_template.copy()
+        self.invalid_ports_form_data["vms_new-0-platform"] = ""  # Invalid id
+        form_data = self.invalid_ports_form_data
+        form = CreateVmForm(data=form_data)
+        with self.assertRaises(ValueError) as context:
+            form.process_creation(form_data)
+        self.assertIn(
+            "Platform cannot be empty", str(context.exception))
+        
+        #invalid Extra Config
+        self.invalid_ports_form_data = self.form_data_template.copy()
+        self.invalid_ports_form_data["vmassignedextraconfig_new-provider_type_extra_config"] = "2"  # Invalid id
+        form_data = self.invalid_ports_form_data
+        form = CreateVmForm(data=form_data)
+        with self.assertRaises(ValueError) as context:
+            form.process_creation(form_data)
+        self.assertIn(
+            "Invalid Extra Config Structure", str(context.exception))
+
 
 
     def tearDown(self):