Code development platform for open source projects from the European Union institutions :large_blue_circle: EU Login authentication by SMS will be completely phased out by mid-2025. To see alternatives please check here

Skip to content
Snippets Groups Projects
Commit 667b6aff authored by Michael KRISPER's avatar Michael KRISPER
Browse files

Cleaned up all remaining TODO's

parent d36952f9
No related branches found
No related tags found
No related merge requests found
......@@ -533,9 +533,7 @@ Public Class VehicleForm
Case CrossWindCorrectionMode.SpeedDependentCorrectionFactor
bEnabled = True
LbCdMode.Text = "Input file: Vehicle Speed [km/h], Cd Scaling Factor [-]" _
'TODO: MQ 20160901: check if scaling factor or absolue value!
LbCdMode.Text = "Input file: Vehicle Speed [km/h], Cd Scaling Factor [-]"
Case Else ' tCdMode.ConstCd0, tCdMode.CdOfVdecl
bEnabled = False
LbCdMode.Text = ""
......
......@@ -290,7 +290,8 @@ Public Class Engine
Public ReadOnly Property Manufacturer As String Implements IComponentInputData.Manufacturer
Get
Return "N.A." ' TODO: MQ 20160919
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
......@@ -308,6 +309,7 @@ Public Class Engine
Public ReadOnly Property CertificationNumber As String Implements IComponentInputData.CertificationNumber
Get
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
......
......@@ -299,7 +299,8 @@ Public Class Gearbox
Public ReadOnly Property Manufacturer As String Implements IComponentInputData.Manufacturer
Get
Return "N.A." ' Todo MQ 20160915
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
......@@ -318,6 +319,7 @@ Public Class Gearbox
Public ReadOnly Property CertificationNumber As String Implements IComponentInputData.CertificationNumber
Get
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
......
......@@ -265,13 +265,15 @@ Public Class Vehicle
Public ReadOnly Property Manufacturer As String Implements IComponentInputData.Manufacturer
Get
Return "N.A." ' TODO: MQ 20160908
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
Public ReadOnly Property Model As String Implements IComponentInputData.Model
Get
Return "N.A." ' Todo: MQ 20160908
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
......@@ -290,7 +292,8 @@ Public Class Vehicle
Public ReadOnly Property CertificationNumber As String Implements IComponentInputData.CertificationNumber
Get
Return "N.A." ' Todo: MQ 20160908
' Just for the interface. Value is not available in GUI yet.
Return "N.A."
End Get
End Property
......
......@@ -474,62 +474,4 @@ Public Class AdvancedAuxiliaries
Return M9.TotalCycleFuelConsumptionCompressorOnContinuously
End Get
End Property
'TODO:REMOVE WHEN TESTING IS COMPLETE - MK2017-06-26: what should be removed? I can't see the "pure-diagnostics"
'PURE DIAGNOSTICS SHOULD ONLY BE USED IN MOD FOR ENGINEERING TESTS
Public ReadOnly Property AA_D_M12_INTERP1 As Kilogram Implements IAdvancedAuxiliaries.AA_D_M12_INTERP1
Get
Return M12.INTRP1()
End Get
End Property
Public ReadOnly Property AA_D_M12_INTERP2 As Kilogram Implements IAdvancedAuxiliaries.AA_D_M12_INTERP2
Get
Return M12.INTRP2()
End Get
End Property
Public ReadOnly Property AA_D_M12_P1X As Joule Implements IAdvancedAuxiliaries.AA_D_M12_P1X
Get
Return M12.P1X()
End Get
End Property
Public ReadOnly Property AA_D_M12_P1Y As Kilogram Implements IAdvancedAuxiliaries.AA_D_M12_P1Y
Get
Return M12.P1Y()
End Get
End Property
Public ReadOnly Property AA_D_M12_P2X As Joule Implements IAdvancedAuxiliaries.AA_D_M12_P2X
Get
Return M12.P2X()
End Get
End Property
Public ReadOnly Property AA_D_M12_P2Y As Kilogram Implements IAdvancedAuxiliaries.AA_D_M12_P2Y
Get
Return M12.P2Y()
End Get
End Property
Public ReadOnly Property AA_D_M12_P3X As Joule Implements IAdvancedAuxiliaries.AA_D_M12_P3X
Get
Return M12.P3X()
End Get
End Property
Public ReadOnly Property AA_D_M12_P3Y As Kilogram Implements IAdvancedAuxiliaries.AA_D_M12_P3Y
Get
Return M12.P3Y()
End Get
End Property
Public ReadOnly Property AA_D_M12_XTAIN As Joule Implements IAdvancedAuxiliaries.AA_D_M12_XTAIN
Get
Return M12.XTAIN()
End Get
End Property
End Class
......@@ -22,18 +22,6 @@ Public Interface IAdvancedAuxiliaries
ReadOnly Property AuxiliaryName As String
ReadOnly Property AuxiliaryVersion As String
'Diagnostic Only - Remove when beta over.
ReadOnly Property AA_D_M12_P1X As Joule
ReadOnly Property AA_D_M12_P1Y As Kilogram
ReadOnly Property AA_D_M12_P2X As Joule
ReadOnly Property AA_D_M12_P2Y As Kilogram
ReadOnly Property AA_D_M12_P3X As Joule
ReadOnly Property AA_D_M12_P3Y As Kilogram
ReadOnly Property AA_D_M12_XTAIN As Joule
ReadOnly Property AA_D_M12_INTERP1 As Kilogram
ReadOnly Property AA_D_M12_INTERP2 As Kilogram
'Additional Permenent Monitoring Signals - Required by engineering
ReadOnly Property AA_NonSmartAlternatorsEfficiency As Double
ReadOnly Property AA_SmartIdleCurrent_Amps As Ampere
......
......@@ -601,7 +601,6 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
Case<ResponseDrivingCycleDistanceExceeded>(r => {
if (!ds.IsEqual(r.MaxDistance)) {
// distance has been reduced due to vehicle stop in coast/roll action => use brake action to get exactly to the stop-distance
// TODO what if no gear is enaged (and we need driveline power to get to the stop-distance?
response = Driver.DrivingActionBrake(absTime, ds, DriverStrategy.BrakeTrigger.NextTargetSpeed, gradient);
}
}).
......
This diff is collapsed.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment