fix: Disable Recommends, improve OCI8 setup (fixes #3)

tasks/main.yml

@@ -6,14 +6,8 @@
   ansible.builtin.include_vars: "{{ ansible_distribution }}.yml"
   when: ansible_distribution == 'Amazon'
 
-- name: Prepare
-  ansible.builtin.include_tasks: "prepare-{{ ansible_os_family }}.yml"
-
-- name: Install PHP packages
-  ansible.builtin.package:
-    name: "{{ php_installed_packages + php_installed_packages_extra }}"
-    state: present
-  become: true
+- name: Setup
+  ansible.builtin.include_tasks: "setup-{{ ansible_os_family }}.yml"
 
 - name: Install OCI8
   ansible.builtin.include_tasks: "oci8-{{ ansible_os_family }}.yml"

tasks/oci8-Debian.yml

@@ -11,20 +11,30 @@
 - name: Set fact OCI8 version
   ansible.builtin.set_fact:
     php_oci8_version: "oci8-3.0.1"
-  when: php_version[:2] == "8.0"
+  when: php_version[:3] == "8.0"
 
-- name: List installed extensions
-  ansible.builtin.command: "pecl list"
-  register: output
-  changed_when: false
-  become: true
+- name: Check ini file
+  ansible.builtin.stat:
+    path: "{{ php_oci8_extension_ini_path }}"
+  register: php_oci8_ini_file
 
 - name: Install OCI8 extension
-  ansible.builtin.shell: "set -o pipefail && printf 'instantclient,{{ php_oracle_instantclient_path }}' | pecl install {{ php_oci8_version }}"
+  block:
+    - name: Install OCI8 extension with pecl
+      ansible.builtin.shell: "set -o pipefail && printf 'instantclient,{{ php_oracle_instantclient_path }}' | pecl -d php_suffix={{ php_version }} install {{ php_oci8_version }}"
       args:
         executable: /bin/bash
-  become: true
-  when: "'oci8' not in output.stdout"
+      register: pecl_result
+      changed_when: "'install ok' in pecl_result.stdout"
+      failed_when: "'install ok' not in pecl_result.stdout"
+
+    - name: Unregister OCI8 extension
+      ansible.builtin.shell: "set -o pipefail && pecl uninstall -r oci8"
+      args:
+        executable: /bin/bash
+      register: pecl_result
+      changed_when: "'uninstall ok' in pecl_result.stdout"
+      failed_when: "'uninstall ok' not in pecl_result.stdout"
 
     - name: Copy OCI8 ini file
       ansible.builtin.copy:
@@ -33,9 +43,12 @@
         owner: root
         group: root
         mode: 'u=rw,go=r'
-  become: true
 
     - name: Enable OCI8 module - CLI
       ansible.builtin.command: "phpenmod oci8"
-  changed_when: false
+      register: cmd_result
+      changed_when: "cmd_result.rc == 0"
+      failed_when: "cmd_result.rc != 0"
+
   become: true
+  when: not php_oci8_ini_file.stat.exists

tasks/prepare-Debian.yml → tasks/setup-Debian.yml

@@ -12,3 +12,10 @@
     state: present
   become: true
   loop: "{{ php_enabled_apt_repos }}"
+
+- name: Install APT PHP packages
+  ansible.builtin.apt:
+    name: "{{ php_installed_packages + php_installed_packages_extra }}"
+    state: present
+    install_recommends: false
+  become: true

tasks/prepare-RedHat.yml → tasks/setup-RedHat.yml

@@ -11,3 +11,9 @@
     name: "{{ php_enabled_yum_repos }}"
     state: present
   become: true
+
+- name: Install Yum PHP packages
+  ansible.builtin.yum:
+    name: "{{ php_installed_packages + php_installed_packages_extra }}"
+    state: present
+  become: true

vars/Debian.yml

@@ -11,6 +11,6 @@ php_installed_packages_extra:
   - "{{ php_package_prefix }}-msgpack"
   - "{{ php_package_prefix }}-phpdbg"
   - "{{ php_package_prefix }}-redis"
-  - "{{ php_package_prefix }}-zip"
+  - "php-pear"
 
 php_xdebug_package: "{{ php_package_prefix }}-xdebug"

vars/RedHat.yml

@@ -17,6 +17,5 @@ php_installed_packages_extra:
   - "{{ php_package_prefix }}-pecl-igbinary"
   - "{{ php_package_prefix }}-pecl-mongodb"
   - "{{ php_package_prefix }}-pecl-redis"
-  - "{{ php_package_prefix }}-pecl-zip"
 
 php_xdebug_package: "{{ php_package_prefix }}-pecl-xdebug"