Code development platform for open source projects from the European Union institutions

Skip to content
Snippets Groups Projects
Commit 4b726f53 authored by Sebastian-Ion TINCU's avatar Sebastian-Ion TINCU
Browse files

EDELIVERY-3762 Clean the smp-angular project from domibus object 

Prefer interfaces to classes where applicable.
parent 3bab4bda
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 96 additions and 185 deletions
smp-angular/src/app/alerts/alertsentry.ts
+ 9
− 12
View file @ 4b726f53
export class AlertsEntry {
constructor(public processed: boolean,
public alertId: string,
public alertType: string,
public alertLevel: string,
public alertText: string,
public creationTime: Date,
public reportingTime: Date,
public parameters: string[])
{
}
export interface AlertsEntry {
processed: boolean;
alertId: string;
alertType: string;
alertLevel: string;
alertText: string;
creationTime: Date;
reportingTime: Date;
parameters: string[];
}
smp-angular/src/app/alerts/alertsresult.ts
+ 7
− 11
View file @ 4b726f53
import {AlertsEntry} from "./alertsentry";
export class AlertsResult {
constructor(public alertsEntries: Array<AlertsEntry>,
public pageSize: number,
public count: number,
public filter: any,
public alertsType: Array<string>,
public alertsLevels: Array<string>
) {
}
export interface AlertsResult {
alertsEntries: Array<AlertsEntry>;
pageSize: number;
count: number;
filter: any;
alertsType: Array<string>;
alertsLevels: Array<string>;
}
smp-angular/src/app/appinfo/domibusinfo.service.ts
+ 1
− 1
View file @ 4b726f53
......@@ -16,7 +16,7 @@ export class DomibusInfoService {
let subject = new ReplaySubject();
this.http.get('rest/application/info')
.map((response: Response) => {
let domibusInfo = new DomibusInfo(response.json().version);
const domibusInfo:DomibusInfo = { version: response.json().version };
return domibusInfo;
})
.subscribe((res: DomibusInfo) => {
......
smp-angular/src/app/appinfo/domibusinfo.ts
+ 2
− 4
View file @ 4b726f53
export class DomibusInfo {
constructor(public version:string) {
}
export interface DomibusInfo {
version:string;
}
smp-angular/src/app/common/searchtable/searchtable-controller.ts
+ 4
− 14
View file @ 4b726f53
export class SearchTableController {
showDetails(row: any) {
}
edit(row: any) {
}
delete(row: any) {
}
export interface SearchTableController {
showDetails(row);
edit(row);
delete(row);
}
smp-angular/src/app/common/searchtable/searchtableresult.ts
+ 5
− 10
View file @ 4b726f53
export class SearchTableResult {
constructor(public serviceEntities: Array<any>,
public pageSize: number,
public count: number,
public filter: any
) {
}
export interface SearchTableResult {
serviceEntities: Array<any>;
pageSize: number;
count: number;
filter: any;
}
smp-angular/src/app/domain/domain-controller.ts
+ 4
− 16
View file @ 4b726f53
......@@ -2,13 +2,9 @@ import {SearchTableController} from "../common/searchtable/searchtable-controlle
import {MdDialog, MdDialogRef} from "@angular/material";
import {DomainDetailsDialogComponent} from "./domain-details-dialog/domain-details-dialog.component";
export class DomainController implements SearchTableController {
export class DomainController extends SearchTableController {
constructor(public dialog: MdDialog) {
super();
}
constructor(public dialog: MdDialog) { }
public showDetails(row: any) {
let dialogRef: MdDialogRef<DomainDetailsDialogComponent> = this.dialog.open(DomainDetailsDialogComponent);
......@@ -16,17 +12,9 @@ export class DomainController extends SearchTableController {
dialogRef.afterClosed().subscribe(result => {
//Todo:
});
}
public edit(row: any) { }
public edit(row: any) {
}
public delete(row: any) {
}
public delete(row: any) { }
}
smp-angular/src/app/domain/domainresult.ts
+ 5
− 9
View file @ 4b726f53
import {DomainRO} from "./domainro";
export class DomainResult {
constructor(public serviceEntities: Array<DomainRO>,
public pageSize: number,
public count: number,
public filter: any
) {
}
export interface DomainResult {
serviceEntities: Array<DomainRO>;
pageSize: number;
count: number;
filter: any;
}
smp-angular/src/app/domain/domainro.ts
+ 6
− 11
View file @ 4b726f53
export class DomainRO {
constructor(public domainId: string,
public bdmslClientCertHeader: string,
public bdmslClientCertAlias: string,
public bdmslSmpId: string,
public signatureCertAlias: string
) {
}
export interface DomainRO {
domainId: string;
bdmslClientCertHeader: string;
bdmslClientCertAlias: string;
bdmslSmpId: string;
signatureCertAlias: string;
}
......
smp-angular/src/app/errorlog/errorlogentry.ts
+ 7
− 10
View file @ 4b726f53
export class ErrorLogEntry {
constructor(errorSignalMessageId: string,
mshRole: string,
messageInErrorId: string,
errorCode: string,
timestamp: Date,
notified: Date) {
}
export interface ErrorLogEntry {
errorSignalMessageId: string,
mshRole: string;
messageInErrorId: string;
errorCode: string;
timestamp: Date;
notified: Date;
}
smp-angular/src/app/errorlog/errorlogresult.ts
+ 10
− 11
View file @ 4b726f53
import {ErrorLogEntry} from "./errorlogentry";
export class ErrorLogResult {
constructor(public errorLogEntries: Array<ErrorLogEntry>,
// public offset: number,
public pageSize: number,
// public orderBy: string,
// public asc: boolean,
public count: number,
public filter: any,
public mshRoles: Array<string>,
public errorCodes: Array<string>) {
}
export interface ErrorLogResult {
errorLogEntries: Array<ErrorLogEntry>;
// offset: number;
pageSize: number;
// orderBy: string;
// asc: boolean;
count: number;
filter: any;
mshRoles: Array<string>;
errorCodes: Array<string>;
}
smp-angular/src/app/messagefilter/messagefilter.component.ts
+ 9
− 9
View file @ 4b726f53
......@@ -117,16 +117,16 @@ export class MessageFilterComponent implements DirtyOperations {
if (result == true) {
let routingCriterias: Array<RoutingCriteriaEntry> = [];
if (!isNullOrUndefined(formRef.componentInstance.from) && formRef.componentInstance.from != "") {
routingCriterias.push(new RoutingCriteriaEntry(0, 'from', formRef.componentInstance.from));
routingCriterias.push({ entityId: 0, name: 'from', expression: formRef.componentInstance.from });
}
if (!isNullOrUndefined(formRef.componentInstance.to) && formRef.componentInstance.to != "") {
routingCriterias.push(new RoutingCriteriaEntry(0, 'to', formRef.componentInstance.to));
routingCriterias.push({ entityId: 0, name: 'to', expression: formRef.componentInstance.to });
}
if (!isNullOrUndefined(formRef.componentInstance.action) && formRef.componentInstance.action != "") {
routingCriterias.push(new RoutingCriteriaEntry(0, 'action', formRef.componentInstance.action));
routingCriterias.push({ entityId: 0, name: 'action', expression: formRef.componentInstance.action });
}
if (!isNullOrUndefined(formRef.componentInstance.service) && formRef.componentInstance.service != "") {
routingCriterias.push(new RoutingCriteriaEntry(0, 'service', formRef.componentInstance.service));
routingCriterias.push({ entityId: 0, name: 'service', expression: formRef.componentInstance.service });
}
let backendEntry = new BackendFilterEntry(0, this.rowNumber + 1, formRef.componentInstance.plugin, routingCriterias, false);
if (this.findRowsIndex(backendEntry) == -1) {
......@@ -178,16 +178,16 @@ export class MessageFilterComponent implements DirtyOperations {
if (result == true) {
let routingCriterias: Array<RoutingCriteriaEntry> = [];
if (!isNullOrUndefined(formRef.componentInstance.from)) {
routingCriterias.push(new RoutingCriteriaEntry(0, 'from', formRef.componentInstance.from));
routingCriterias.push({ entityId: 0, name: 'from', expression: formRef.componentInstance.from });
}
if (!isNullOrUndefined(formRef.componentInstance.to)) {
routingCriterias.push(new RoutingCriteriaEntry(0, 'to', formRef.componentInstance.to));
routingCriterias.push({ entityId: 0, name: 'to', expression: formRef.componentInstance.to });
}
if (!isNullOrUndefined(formRef.componentInstance.action)) {
routingCriterias.push(new RoutingCriteriaEntry(0, 'action', formRef.componentInstance.action));
routingCriterias.push({ entityId: 0, name: 'action', expression: formRef.componentInstance.action });
}
if (!isNullOrUndefined(formRef.componentInstance.service)) {
routingCriterias.push(new RoutingCriteriaEntry(0, 'service', formRef.componentInstance.service));
routingCriterias.push({ entityId: 0, name: 'service', expression: formRef.componentInstance.service });
}
let backendEntry = new BackendFilterEntry(0, this.rowNumber + 1, formRef.componentInstance.plugin, routingCriterias, false);
let backendEntryPos = this.findRowsIndex(backendEntry);
......@@ -224,7 +224,7 @@ export class MessageFilterComponent implements DirtyOperations {
if (value.length == 0) {
return;
}
let newRC = new RoutingCriteriaEntry(null, rc, value);
let newRC = { name: rc, expression: value };
this.rows[this.rowNumber].routingCriterias.push(newRC);
this.createValueProperty(rc, newRC, this.rowNumber);
}
......
smp-angular/src/app/messagefilter/messagefilterresult.ts
+ 3
− 3
View file @ 4b726f53
import {BackendFilterEntry} from "./backendfilterentry";
export class MessageFilterResult {
constructor(public messageFilterEntries: Array<BackendFilterEntry>, public areFiltersPersisted: boolean) {
}
export interface MessageFilterResult {
messageFilterEntries: Array<BackendFilterEntry>;
areFiltersPersisted: boolean;
}
smp-angular/src/app/messagefilter/routingcriteriaentry.ts
+ 4
− 8
View file @ 4b726f53
export class RoutingCriteriaEntry {
public constructor(
public entityId: number,
public name: string,
public expression: string
) {
}
export interface RoutingCriteriaEntry {
entityId?: number;
name: string;
expression: string;
}
smp-angular/src/app/security/domain.ts
+ 2
− 5
View file @ 4b726f53
export class Domain {
export interface Domain {
code: string;
name: string;
constructor(code: string, name: string) {
}
name: string;
}
smp-angular/src/app/security/user.ts
+ 2
− 5
View file @ 4b726f53
export class User {
export interface User {
id: number;
username: string;
authorities: Array<string>;
defaultPasswordUsed:boolean;
constructor(id: number, login: string, profile: string, authorities: Array<string>,defaultPasswordUsed:boolean) {
}
defaultPasswordUsed: boolean;
}
smp-angular/src/app/servicegroup/servicegroup-controller.ts
+ 4
− 13
View file @ 4b726f53
......@@ -6,12 +6,9 @@ import {AlertService} from "../alert/alert.service";
import {ServiceGroupExtensionDialogComponent} from "./servicegroup-extension-dialog/servicegroup-extension-dialog.component";
import {ServicegroupMetadatalistDialogComponent} from "./servicegroup-metadatalist-dialog/servicegroup-metadatalist-dialog.component";
export class ServiceGroupController extends SearchTableController {
constructor(public dialog: MdDialog) {
super();
}
export class ServiceGroupController implements SearchTableController {
constructor(public dialog: MdDialog) { }
public showDetails(row: any) {
let dialogRef: MdDialogRef<ServicegroupDetailsDialogComponent> = this.dialog.open(ServicegroupDetailsDialogComponent);
......@@ -19,7 +16,6 @@ export class ServiceGroupController extends SearchTableController {
dialogRef.afterClosed().subscribe(result => {
//Todo:
});
}
public showExtension(row: any) {
......@@ -36,15 +32,10 @@ export class ServiceGroupController extends SearchTableController {
dialogRef.afterClosed().subscribe(result => {
//Todo:
});
}
public edit(row: any) {
public edit(row: any) { }
}
public delete(row: any) {
}
public delete(row: any) { }
}
smp-angular/src/app/servicegroup/servicegroupro.ts
+ 6
− 14
View file @ 4b726f53
export class ServiceGroupRO {
constructor(public serviceGroupROId: ServiceGroupROId,
public domain: string
) {
}
export interface ServiceGroupRO {
serviceGroupROId: ServiceGroupROId;
domain: string;
}
class ServiceGroupROId {
constructor(public participantId: string,
public participantSchema: string
) {
}
export interface ServiceGroupROId {
participantId: string;
participantSchema: string;
}
smp-angular/src/app/truststore/trustore.model.ts
+ 2
− 3
View file @ 4b726f53
/**
* @author Thomas Dussart
* @since 3.3
*/
export class TrustStoreEntry {
name: string
export interface TrustStoreEntry {
name: string;
subject: string;
issuer: string;
validFrom: string;
......
smp-angular/src/app/user/user-controller.ts
+ 4
− 16
View file @ 4b726f53
......@@ -2,13 +2,9 @@ import {SearchTableController} from "../common/searchtable/searchtable-controlle
import {MdDialog, MdDialogRef} from "@angular/material";
import {UserDetailsDialogComponent} from "./user-details-dialog/user-details-dialog.component";
export class UserController implements SearchTableController {
export class UserController extends SearchTableController {
constructor(public dialog: MdDialog) {
super();
}
constructor(public dialog: MdDialog) { }
public showDetails(row: any) {
let dialogRef: MdDialogRef<UserDetailsDialogComponent> = this.dialog.open(UserDetailsDialogComponent);
......@@ -16,17 +12,9 @@ export class UserController extends SearchTableController {
dialogRef.afterClosed().subscribe(result => {
//Todo:
});
}
public edit(row: any) { }
public edit(row: any) {
}
public delete(row: any) {
}
public delete(row: any) { }
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

For further information about the platform and support, please see https://code.europa.eu/info/about