Code development platform for open source projects from the European Union institutions :large_blue_circle: EU Login authentication by SMS will be completely phased out by mid-2025. To see alternatives please check here

Skip to content
Snippets Groups Projects
Commit 67c5cea9 authored by Joze RIHTARSIC's avatar Joze RIHTARSIC
Browse files

[EDELIVERY-13874] fix UI group dialog name validation

parent a2002feb
No related branches found
No related tags found
No related merge requests found
......@@ -7,6 +7,8 @@
<input id="name_id" type="text" matInput formControlName="name"
required>
<mat-hint >{{ "group.dialog.hint.group.name" | translate }}</mat-hint>
<smp-field-error *ngIf="inputDataError('name', 'maxlength')">{{ "group.dialog.error.group.name.length" | translate }}
</smp-field-error >
</mat-form-field>
<mat-form-field style="width: 100%">
......
import {Component, Inject, Input} from '@angular/core';
import {MAT_DIALOG_DATA, MatDialogRef} from '@angular/material/dialog';
import {FormBuilder, FormControl, FormGroup} from "@angular/forms";
import {FormBuilder, FormControl, FormGroup, Validators} from "@angular/forms";
import {DomainRo} from "../../../../common/model/domain-ro.model";
import {AlertMessageService} from "../../../../common/alert-message/alert-message.service";
import {VisibilityEnum} from "../../../../common/enums/visibility.enum";
......@@ -38,7 +38,7 @@ export class GroupDialogComponent {
this._currentDomain = data.domain;
this.groupForm = formBuilder.group({
'name': new FormControl({value: null}),
'name': new FormControl({value: null}, Validators.maxLength(512)),
'description': new FormControl({value: null}),
'visibility': new FormControl({value: null}),
'': new FormControl({value: null})
......@@ -117,7 +117,10 @@ export class GroupDialogComponent {
}, (error) => {
this.alertService.error(error.error?.errorDescription)
});
}
public inputDataError = (controlName: string, errorName: string) => {
return this.groupForm.controls[controlName].hasError(errorName);
}
public saveGroup(group: GroupRo) {
......
......@@ -245,6 +245,7 @@
"group.dialog.label.group.visibility": "Group visibility",
"group.dialog.placeholder.group.visibility": "Group visibility",
"group.dialog.tooltip.group.visibility": "Group visibility.",
"group.dialog.error.group.name": "Group name must not be empty and shorter than 512 characters.",
"domain.group.button.create": "Create",
"domain.group.button.delete": "Delete",
"domain.group.button.edit": "Edit data",
......
......@@ -21,8 +21,12 @@ package eu.europa.ec.edelivery.smp.data.model;
/**
* Created by gutowpa on 01/02/2017.
*
* @since 3.0
* @author Pawel GUTOWSKI
*/
public class CommonColumnsLengths {
public static final int MAX_DOMAIN_CODE_LENGTH = 256;
public static final int MAX_FREE_TEXT_LENGTH = 4000;
public static final int MAX_MEDIUM_TEXT_LENGTH = 1024;
......@@ -36,13 +40,14 @@ public class CommonColumnsLengths {
public static final int MAX_SML_SUBDOMAIN_LENGTH = 256;
public static final int MAX_SML_SMP_ID_LENGTH = 256;
public static final int MAX_USER_ROLE_LENGTH = 256;
public static final int MAX_TEXT_LENGTH_256 = 512;
public static final int MAX_TEXT_LENGTH_256 = 256;
public static final int MAX_TEXT_LENGTH_512 = 512;
public static final int MAX_TEXT_LENGTH_128 = 128;
public static final int MAX_TEXT_LENGTH_64 = 64;
/**
* Private constructor to prevent instantiation.
*/
private CommonColumnsLengths() {
}
}
......@@ -68,7 +68,7 @@ public class DBExtension extends BaseEntity {
@Column(name = "DESCRIPTION", length = CommonColumnsLengths.MAX_TEXT_LENGTH_512 )
private String description;
@Column(name = "IMPLEMENTATION_NAME", length = CommonColumnsLengths.MAX_TEXT_LENGTH_256 )
@Column(name = "IMPLEMENTATION_NAME", length = CommonColumnsLengths.MAX_TEXT_LENGTH_512 )
private String implementationName;
......
......@@ -101,7 +101,7 @@ public class DBResourceDef extends BaseEntity {
@ColumnDescription(comment = "resources are published under url_segment.")
String urlSegment;
@Column(name = "HANDLER_IMPL_NAME", length = CommonColumnsLengths.MAX_TEXT_LENGTH_256 )
@Column(name = "HANDLER_IMPL_NAME", length = CommonColumnsLengths.MAX_TEXT_LENGTH_512 )
private String handlerImplementationName;
@ManyToOne(fetch = FetchType.LAZY)
......
......@@ -76,7 +76,7 @@ public class DBSubresourceDef extends BaseEntity {
@ColumnDescription(comment = "Subresources are published under url_segment. It must be unique for resource type")
private String urlSegment;
@Column(name = "HANDLER_IMPL_NAME", length = CommonColumnsLengths.MAX_TEXT_LENGTH_256 )
@Column(name = "HANDLER_IMPL_NAME", length = CommonColumnsLengths.MAX_TEXT_LENGTH_512 )
private String handlerImplementationName;
@Override
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment