[REGRESSION] Reviewer role user cannot create annotations

SUMMARY

Reviewer role user cannot create annotations due to regression introduced in annotate#259 (closed).

If a reviewer user selects some text, the popup to create annotations should be presented:

But this is not the case.

After debugging, it was concluded that the issue comes from a regression introduced in annotate#259 (closed), on the logic to trigger the show/not show of annotations creation popup:

Rules:

Explanation:

By checking on "CAN_UPDATE" permission to determine if the popup should be presented works for the VIEWER role, but it has implications on the REVIEWER role as well, since REVIEWERS also don't have the CAN_UPDATE permission

SCOPE:

• Fix the logic to have the expected behavior
• Ensure this logic is not applied elsewhere (document notes for example?)
• Be sure to cover test cases for all roles in order to detect misconfigurations in the future

ACCEPTANCE CRITERIAS / GOALS

• Reviewer role user must be able to create annotations
• Viewer role user must not be able to create annotations

RELEASE AND BUILD VERSION

Version: 5.2.2 | Revision: EdiT Drafting | Date: 2025-01-31 16:57 CET

BROWSER USED

Google chrome

STEPS TO REPRODUCE

• Create a proposal
• Add a user as reviewer to it
• login with the reviewer user
• open the legal act (for example)
• select some text to create an annotation, the popup will not be presented