Code development platform for open source projects from the European Union institutions

Skip to content
Snippets Groups Projects

OEL-1662: Add registration URL field to the full content view

Merged Francesco SARDARA requested to merge OEL-1662 into 1.x

Created by: escuriola

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Francesco SARDARA
    Francesco SARDARA @brummbar started a thread on commit aa524aa9
  • 130 131 trim($content_banner->filter('.oe-sc-event__oe-summary')->text())
    131 132 );
    132 133
    134 // Assert registration button.
    135 $link = $crawler->filter('div.container > div.row > div.col-8 > a[target="_blank"]');
    136 $this->assertCount(1, $link);
  • Francesco SARDARA
  • Francesco SARDARA
  • Created by: drishu

    Review: Changes requested

    I wont ask for a dedicated test for the formatter since we are out of time

  • Francesco SARDARA changed title from OEL-1162: Add registration URL field to the full content view to OEL-1662: Add registration URL field to the full content view

    changed title from OEL-1162: Add registration URL field to the full content view to OEL-1662: Add registration URL field to the full content view

  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
    Francesco SARDARA @brummbar started a thread on commit e970b337
  • 130 131 trim($content_banner->filter('.oe-sc-event__oe-summary')->text())
    131 132 );
    132 133
    134 // Assert registration button.
    135 $link = $crawler->filter('.bcl-content-banner a[target="_blank"]');
    136 $this->assertCount(1, $link);
    137 $button = $link->filter('button');
    138 $this->assertStringContainsString('Register', $button->text());
    139 $this->assertStringContainsString('calendar-check', $button->html());
    140
    • Created by: donquixote

      Given that we already have $link as a separate variable, we should also assert the href attribute.

    • Created by: donquixote

      And we should test one version with an internal link. The test in oe_starter_content does not count for this because we don't have the formatter there.

  • Created by: donquixote

    Review: Changes requested

    Some notes, and some changes to be done.

  • Francesco SARDARA
  • Francesco SARDARA
  • Created by: donquixote

    Review: Approved

  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading