Code development platform for open source projects from the European Union institutions

Skip to content
Snippets Groups Projects

OEL-1326: Cleaning patterns & paragraphs from OEL-755

Merged OEL-1326: Cleaning patterns & paragraphs from OEL-755
OEL-1326 into 1.x
Merged Francesco SARDARA requested to merge OEL-1326 into 1.x

Merge request reports

Approval is optional

Merged by Francesco SARDARAFrancesco SARDARA 2 years ago (Aug 5, 2022 7:52am UTC)

Merge details

  • Changes merged into 1.x with 0cb544bb.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
modules/oe_whitelabel_paragraphs/tests/src/Kernel/Paragraphs/ListingParagraphsTest.php
174 168 'alt' => 'Alt for image ' . $i,
175 169 'target_id' => $image_file->id(),
176 170 ],
177 'field_oe_date' => '2011-11-13',
  • Francesco SARDARA
    Francesco SARDARA @brummbar ·
    Author Owner

    Created by: donquixote

    From the other PR oe_bootstrap_theme:191:

    you don't need all this, you'r not asserting the paragraph content in this test, and that is ok, you don't need date, you dont need image, you dont need most, add just minimal and use a random function instead where needed

  • Francesco SARDARA
    Francesco SARDARA @brummbar ·
    Author Owner

    Created by: donquixote

    Not sure if anything else should be removed here. But I am going to assume it is ok.

  • Francesco SARDARA
    Francesco SARDARA @brummbar ·
    Author Owner

    Created by: brummbar

    Review: Approved

  • Francesco SARDARA
    Francesco SARDARA @brummbar ·
    Author Owner

    Created by: drishu

    Review: Approved

  • Francesco SARDARA
    Francesco SARDARA @brummbar ·
    Author Owner

    Merged by: brummbar at 2022-08-05 07:52:13 UTC

  • Francesco SARDARA closed

    closed

  • Francesco SARDARA merged manually

    merged manually

    • Please register or sign in to reply

    For further information about the platform and support, please see https://code.europa.eu/info/about