Code development platform for open source projects from the European Union institutions

Skip to content
Snippets Groups Projects

OEL-541: search box

Merged Francesco SARDARA requested to merge OEL-541 into 1.x

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Francesco SARDARA
  • Francesco SARDARA
    Francesco SARDARA @brummbar started a thread on commit 00c0fac4
  • 119 '#title' => $this->t('Button icon name'),
    120 '#description' => $this->t('Ex: search.'),
    121 '#default_value' => $config['button']['icon']['name'],
    122 ];
    123 $form['button_icon_position'] = [
    124 '#type' => 'textfield',
    125 '#title' => $this->t('Button icon position'),
    126 '#description' => $this->t('The position of the icon inside the button.'),
    127 '#default_value' => $config['button']['icon']['position'],
    128 ];
    129 $form['enable_autocomplete'] = [
    130 '#type' => 'checkbox',
    131 '#title' => $this->t('Enable autocomplete'),
    132 '#default_value' => $config['view_options']['enable_autocomplete'] ?? 0,
    133 ];
    134 $form['view_id'] = [
    • Created by: abel-santos-corral

      This field has to include a better message. If view used at oe_whitelabel (on oe_showcase is working smooth) there's an error breaking drupal: InvalidArgumentException: Search entity with ID "serapi" not found. in Drupal\search_api_autocomplete\Element\SearchApiAutocomplete::processSearchApiAutocomplete() (line 62 of /var/www/html/build/modules/contrib/search_api_autocomplete/src/Element/SearchApiAutocomplete.php).

      For me there must be a different color for this widget so when configuring the site builder will take more care in filling ok.

    • Created by: abel-santos-corral

      A validation must be added at a validateForm function to check view_id and view_display exist...if view is not avail, then don't show block, show a message on the block and log. But don't break

    • Created by: abel-santos-corral

      Form action: Description proposed: The url the form should submit to. Is the url of the Search API view set at the view page settings.

      Input name: Description proposed: A name for the search input. Is the Query parameter of the contextual filter used at the Search API view.

      View id: Description proposed: The view id will be the machine name for the Search API View.

      View display: Description proposed: The view display will be the machine name of the display used, at the views settings in the advanced section.

    • Created by: drishu

      add rather a check if views and search api are enabled

  • Created by: abel-santos-corral

    Review: Changes requested

    Please check the issue found.

  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
    Francesco SARDARA @brummbar started a thread on commit b78c534a
  • 1 # OpenEuropa Whitelabel Search
    2
    3 This module offers a searchbox block handled by a plugin.
    4
    5 # Requirements
    6
    7 The following modules must be installed and enabled to use the Search Box block:
    8 - [Search_api](https://www.drupal.org/project/search_api)
    9 - [Search_api_autocomplete](https://www.drupal.org/project/search_api_autocomplete)
    10 - [Views](https://www.drupal.org/docs/8/core/modules/views)
    11 - [Views UI](https://www.drupal.org/docs/8/core/modules/views-ui)
    12
  • Francesco SARDARA
    Francesco SARDARA @brummbar started a thread on commit b78c534a
  • 1 block.settings.whitelabel_search_block:
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Francesco SARDARA
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading