Code development platform for open source projects from the European Union institutions :large_blue_circle: EU Login authentication by SMS has been phased out. To see alternatives please check here

Skip to content
Snippets Groups Projects
Commit 8b2e58d3 authored by Michael KRISPER's avatar Michael KRISPER
Browse files

updated todo comments (more uniform format) and removed some (vair and beta input check)

parent 319b1bee
Branches
Tags
No related merge requests found
Showing with 10 additions and 13 deletions
...@@ -185,7 +185,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.JSON ...@@ -185,7 +185,7 @@ namespace TUGraz.VectoCore.InputData.FileIO.JSON
public virtual bool Enabled public virtual bool Enabled
{ {
get { return false; // TODO @@@ get { return false; // TODO mk-2016-05-09: JSON ITorqueConverterInputData.Enabled always true --> as soon as TC is implemented, set to correct value!
} }
} }
......
...@@ -164,7 +164,7 @@ namespace TUGraz.VectoCore.InputData.Reader.DataObjectAdaper ...@@ -164,7 +164,7 @@ namespace TUGraz.VectoCore.InputData.Reader.DataObjectAdaper
if (gearCurve == null) { if (gearCurve == null) {
return engineCurve; return engineCurve;
} }
// TODO MK-2016-04-18: also combine the curves at the intersection-points of line segments! // TODO mk-2016-04-18: also combine the curves at the intersection-points of line segments!
var entries = var entries =
gearCurve.FullLoadEntries.Concat(engineCurve.FullLoadEntries) gearCurve.FullLoadEntries.Concat(engineCurve.FullLoadEntries)
.OrderBy(x => x.EngineSpeed) .OrderBy(x => x.EngineSpeed)
......
...@@ -538,7 +538,6 @@ namespace TUGraz.VectoCore.InputData.Reader ...@@ -538,7 +538,6 @@ namespace TUGraz.VectoCore.InputData.Reader
public static bool ValidateHeader(string[] header, bool throwExceptions = true) public static bool ValidateHeader(string[] header, bool throwExceptions = true)
{ {
//todo mk-2016-02-15: check if vair_res, and vair_beta only when needed
var allowedCols = new[] { var allowedCols = new[] {
Fields.Time, Fields.Time,
Fields.VehicleSpeed, Fields.VehicleSpeed,
...@@ -586,7 +585,6 @@ namespace TUGraz.VectoCore.InputData.Reader ...@@ -586,7 +585,6 @@ namespace TUGraz.VectoCore.InputData.Reader
public static bool ValidateHeader(string[] header, bool throwExceptions = true) public static bool ValidateHeader(string[] header, bool throwExceptions = true)
{ {
//todo mk-2016-02-15: check if vair_res, and vair_beta only when needed
var allowedCols = new[] { var allowedCols = new[] {
Fields.Time, Fields.Time,
Fields.VehicleSpeed, Fields.VehicleSpeed,
......
...@@ -48,7 +48,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Data.Gearbox ...@@ -48,7 +48,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Data.Gearbox
[Required, Range(double.Epsilon, 25)] [Required, Range(double.Epsilon, 25)]
public double Ratio { get; internal set; } public double Ratio { get; internal set; }
public bool TorqueConverterActive { get; internal set; } // TODO: think about refactoring... public bool TorqueConverterActive { get; internal set; } // TODO mk-2016-05-09: Refactor TorqueConverterActive Flag when implementing Torque Converter
// public double AverageEfficiency { get; internal set; } // public double AverageEfficiency { get; internal set; }
} }
......
...@@ -337,7 +337,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl ...@@ -337,7 +337,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
var fc = ModelData.ConsumptionMap.GetFuelConsumption(CurrentState.EngineTorque, avgEngineSpeed, var fc = ModelData.ConsumptionMap.GetFuelConsumption(CurrentState.EngineTorque, avgEngineSpeed,
allowExtrapolation: (DataBus.ExecutionMode != ExecutionMode.Declaration)); allowExtrapolation: (DataBus.ExecutionMode != ExecutionMode.Declaration));
//todo (MK, 2015-11-11): calculate aux start stop correction when start stop functionality is implemented in v3 //TODO mk-2015-11-11: calculate aux start stop correction
var fcAux = fc; var fcAux = fc;
var fcWHTC = fcAux * ModelData.WHTCCorrectionFactor; var fcWHTC = fcAux * ModelData.WHTCCorrectionFactor;
......
...@@ -541,7 +541,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl ...@@ -541,7 +541,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
Case<ResponseDrivingCycleDistanceExceeded>(r => { Case<ResponseDrivingCycleDistanceExceeded>(r => {
if (!ds.IsEqual(r.MaxDistance)) { if (!ds.IsEqual(r.MaxDistance)) {
// distance has been reduced due to vehicle stop in coast/roll action => use brake action to get exactly to the stop-distance // distance has been reduced due to vehicle stop in coast/roll action => use brake action to get exactly to the stop-distance
// TODO: what if no gear is enaged (and we need driveline power to get to the stop-distance? // TODO what if no gear is enaged (and we need driveline power to get to the stop-distance?
response = Driver.DrivingActionBrake(absTime, ds, DriverStrategy.BrakeTrigger.NextTargetSpeed, gradient); response = Driver.DrivingActionBrake(absTime, ds, DriverStrategy.BrakeTrigger.NextTargetSpeed, gradient);
} }
}). }).
......
...@@ -223,7 +223,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl ...@@ -223,7 +223,7 @@ namespace TUGraz.VectoCore.Models.SimulationComponent.Impl
} }
IResponse retVal; IResponse retVal;
// TODO: MQ 2016/03/10: investigate further the effects of having the condition angularvelocity != 0 // TODO MQ 2016/03/10: investigate further the effects of having the condition angularvelocity != 0
if (ClutchClosed(absTime) /* && !angularVelocity.IsEqual(0) */) { if (ClutchClosed(absTime) /* && !angularVelocity.IsEqual(0) */) {
retVal = RequestGearEngaged(absTime, dt, torque, angularVelocity, dryRun); retVal = RequestGearEngaged(absTime, dt, torque, angularVelocity, dryRun);
} else { } else {
......
...@@ -233,7 +233,7 @@ namespace TUGraz.VectoCore.OutputData ...@@ -233,7 +233,7 @@ namespace TUGraz.VectoCore.OutputData
public static WattSecond WorkTorqueConverter(this IModalDataContainer data) public static WattSecond WorkTorqueConverter(this IModalDataContainer data)
{ {
//TODO (MK, 2015-11-10): return torque converter work - this was currently not possible because torque converter is not implemented. //TODO mk-2015-11-10: return torque converter work when TorqueConverter is implemented
return 0.SI<WattSecond>(); return 0.SI<WattSecond>();
} }
......
...@@ -296,7 +296,6 @@ namespace TUGraz.VectoCore.Tests.Integration.SimulationRuns ...@@ -296,7 +296,6 @@ namespace TUGraz.VectoCore.Tests.Integration.SimulationRuns
@"TestData\job_1-Gear-Test-dist.vmod", testRowCount: false); @"TestData\job_1-Gear-Test-dist.vmod", testRowCount: false);
} }
// todo: add realistic FullLoadCurve
private static GearboxData CreateGearboxData() private static GearboxData CreateGearboxData()
{ {
var ratios = new[] { 6.38, 4.63, 3.44, 2.59, 1.86, 1.35, 1, 0.76 }; var ratios = new[] { 6.38, 4.63, 3.44, 2.59, 1.86, 1.35, 1, 0.76 };
...@@ -305,9 +304,9 @@ namespace TUGraz.VectoCore.Tests.Integration.SimulationRuns ...@@ -305,9 +304,9 @@ namespace TUGraz.VectoCore.Tests.Integration.SimulationRuns
Gears = ratios.Select((ratio, i) => Gears = ratios.Select((ratio, i) =>
Tuple.Create((uint)i, Tuple.Create((uint)i,
new GearData { new GearData {
// TODO mk-2016-05-09: add realistic FullLoadCurve for gearbox
FullLoadCurve = FullLoadCurveReader.ReadFromFile(GearboxFullLoadCurveFile), FullLoadCurve = FullLoadCurveReader.ReadFromFile(GearboxFullLoadCurveFile),
LossMap = LossMap = TransmissionLossMap.ReadFromFile(GearboxLossMap, ratio, string.Format("Gear {0}", i)),
TransmissionLossMap.ReadFromFile(GearboxLossMap, ratio, string.Format("Gear {0}", i)),
Ratio = ratio, Ratio = ratio,
ShiftPolygon = ShiftPolygonReader.ReadFromFile(GearboxShiftPolygonFile) ShiftPolygon = ShiftPolygonReader.ReadFromFile(GearboxShiftPolygonFile)
})) }))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment